[pull] main from bvaughn:main #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary change in this version is to the `Group` component, which now sets default `width`, `height`, and `overflow` styles. (Both can be overridden using the `style` property.) This is being done to improve DevX and reduce confusion with groups either being invisible or too tall. This mirrors the behavior of default group styles in versions 2 and 3.: https://github.com/bvaughn/react-resizable-panels/blob/43a071df6bb96d54e8b81a6be0e2d453af45cc4b/packages/react-resizable-panels/src/PanelGroup.ts#L933-L939 > [!NOTE] > Is this a breaking change or a bug fix? I see arguments for both sides. I lean towards thinking of it as a bug fix though, after having migrated a lot of apps from version 3 to 4 today. I think this behavior is a more intuitive _default_ that can still be overridden in several ways. This version also includes the following minor changes: - Drag interactions only call `event.preventDefault` for the primary button - Refine TS types for `useGroupRef` and `usePanelRef` to include `| null` to increase compatibility with older React versions - Update TSDoc comments for `Panel` and `Separator` components
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )