Skip to content

[pull] main from Shopify:main #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 4 commits into from
Dec 17, 2025
Merged

[pull] main from Shopify:main #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55181ea
chore(🐙): Switch to OIDC (#3617)
wcandillon Dec 17, 2025
a3dcac1
chore(🐙): remove npm update step from GitHub action (#3618)
wcandillon Dec 17, 2025
e9d10f3
fix(🐛): avoid dangling pointer when reading runtime shader child name…
subraatakumar Dec 17, 2025
32585ed
chore(🐙): remove old npm token configuration from publish command (#3…
wcandillon Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ runs:
node-version-file: .nvmrc
cache: yarn
cache-dependency-path: yarn.lock
registry-url: 'https://registry.npmjs.org'

- name: Install dependencies
run: yarn install --immutable
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ jobs:
yarn release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
YARN_NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
YARN_NPM_AUTH_TOKEN: ''
NPM_TOKEN: ''
NPM_CONFIG_PROVENANCE: true

- name: Deploy to GitHub Pages
Expand Down
2 changes: 1 addition & 1 deletion packages/skia/.releaserc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
[
"@semantic-release/exec",
{
"publishCmd": "mkdir -p /tmp/npm-publish && cp dist/*.tgz /tmp/npm-publish/ && cd /tmp/npm-publish && npm config set //registry.npmjs.org/:_authToken $NPM_TOKEN && npm publish *.tgz --provenance --access public --tag ${nextRelease.channel || 'latest'}"
"publishCmd": "mkdir -p /tmp/npm-publish && cp dist/*.tgz /tmp/npm-publish/ && cd /tmp/npm-publish && npm publish *.tgz --provenance --access public --tag ${nextRelease.channel || 'latest'}"
}
],
[
Expand Down
6 changes: 4 additions & 2 deletions packages/skia/cpp/api/JsiSkImageFilterFactory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,11 @@ class JsiSkImageFilterFactory : public JsiSkHostObject {
JSI_HOST_FUNCTION(MakeRuntimeShader) {
auto rtb = JsiSkRuntimeShaderBuilder::fromValue(runtime, arguments[0]);

const char *childName = "";
std::string childNameStr = "";
const char *childName = childNameStr.c_str();
if (hasOptionalArgument(arguments, count, 1)) {
childName = arguments[1].asString(runtime).utf8(runtime).c_str();
childNameStr = arguments[1].asString(runtime).utf8(runtime);
childName = childNameStr.c_str();
}

sk_sp<SkImageFilter> input = nullptr;
Expand Down
Loading