[pull] main from cloudflare:main #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All test suites in the partysocket package have been marked as skipped using describe.skip. This change is likely for temporarily disabling tests, possibly for debugging, CI performance, or to address failing/flaky tests. Also, the 'all' script in package.json was updated to use 'npm i' instead of 'tsx i'.
Introduces an `enabled` option to both `usePartySocket` and `useWebSocket` hooks, allowing conditional control over socket connection state. Updates internal logic to handle connection, disconnection, and reconnection based on the `enabled` prop. Adds comprehensive tests to verify the new behavior.
…Event React Native/Expo environments have both `process` and `document` polyfilled, but not `process.versions.node`. This caused the library to incorrectly use browser-style event cloning, which produces events that fail `instanceof Event` checks in event-target-polyfill. This fix adds explicit React Native detection using the standard `navigator.product === "ReactNative"` check, and uses Node-style event cloning which creates proper Event instances. Fixes #257
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )