[pull] canary from vercel:canary #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: jiachi <jiachi@vercel.com>
Fixes: #84129 TODO: - [x] e2e test (?) - [x] verify against repro steps in source issue --------- Co-authored-by: Steven <steven@ceriously.com> Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
# What Make the globals we pass to the workers configurable by the browser chunking context. # Why We don't want to hardcode knowledge of next.js, but we need to pass the deployment ID (in `NEXT_DEPLOYMENT_ID`) up to all workers. # How The chunking context provides `worker_forwarded_globals` that are passed into `getWorkerURL` which then passes them to the worker entrypoint via the `params=` mechanism. We switch to using an array of `params` rather than an object as the deserialization code is now mechanically generated.
Follow-up to #89206 this accepts the new script paths as inputs and skips our own adapter's job when these are provided.
Nearly all tasks are 'persistent' and we need to set this field as part of task execution (and read it as part of task invalidation) By keeping it `inline` we can avoid an entry in the lazy vec which should accelerate other accesses and save memory (it would be 56 bytes in the vec, but it is 8 bytes when stored inline) Saves quite a bit of memory 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )