Conversation
# Why update workflow doc for fingerprint and repack params close ENG-17737 --------- Co-authored-by: Aman Mittal <amandeepmittal@live.com>
# Why Closes #44164 The `expo-image-picker` `ExpoCropImageActivity` doesn't handle edge-to-edge display properly on Android. The crop view overlaps with system bars and display cutouts, and the status bar theming uses the deprecated `window.statusBarColor` API (that has no effect on Android 16+). # How - Enabled edge-to-edge rendering with `WindowCompat.enableEdgeToEdge`. - Added window insets listeners to properly inset the `CropImageView` margins so it avoids system bars. - Replaced the deprecated `window.statusBarColor` with a custom status bar background view sized dynamically via insets. - Apply both status and navigation bar style. - Inlined the palette/theming logic from `ExpoCropImageUtils` directly into `ExpoCropImageActivity`, removing the now-unused `applyPaletteToOptions` and `applyWindowTheming` utility methods. - Added `androidx.core:core-ktx:1.17.0` dependency for `enableEdgeToEdge` / `updateLayoutParams`. # Test Plan - Open the image picker with cropping enabled on an Android device with edge-to-edge display (Android 15+). Verify the crop view doesn't overlap with the status bar, navigation bar, or display cutouts. Test in both light and dark modes. - Do the same test on Android < 15. It should be edge-to-edge too. # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) # Screenshots ### Android 16 - Light mode <img width="265" height="489" alt="Screenshot 2026-03-24 at 20 22 34" src="https://github.com/user-attachments/assets/56754ea7-3e85-4780-b453-73968263c697" /> ### Android 16 - Dark mode <img width="265" height="489" alt="Screenshot 2026-03-24 at 20 25 35" src="https://github.com/user-attachments/assets/cbd5c9d9-282b-4e31-bae1-c1fb3bde1329" /> ### Android 16 - Custom colors <img width="265" height="489" alt="Screenshot 2026-03-24 at 20 27 21" src="https://github.com/user-attachments/assets/c60376c7-cce4-4b6f-97e2-47a2a71d38ea" /> ### Android 14 - Light mode <img width="260" height="483" alt="Screenshot 2026-03-24 at 20 29 50" src="https://github.com/user-attachments/assets/bff85951-423a-4d66-a18b-95a8239ea47e" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )