Conversation
# Why For observability/metrics, and for other use cases, we would like to have a more full featured native interface, so that third party modules can get information on the state of updates in a consistent way. Part of this work was added to `expo-updates-interface` earlier to support metrics. This PR adds to that, and provides a unified interface that works whether updates is enabled or disabled. The old interface used by dev launcher is renamed, and now inherits from the new unified interface. In addition to providing information like the IDs of the running or the embedded update, the new interfaces allow third party modules to register a listener for updates state machine transitions. This is an un-revert of #41527, with a fix in Android expo-dev-launcher, and additional CI. # How - Renamed the existing interface for dev launcher - Added new interface definitions - Added code so that `UpdatesControllerRegistry.controller` has a reference to the updates controller in all cases (disabled, enabled, dev launcher) - Added code to the Updates E2E test native module and to the test JS app to demonstrate the interface and the state machine listener feature # Test Plan - New tests and features in the updates E2E tests to exercise the new functionality - Manual testing in a branch of UpdatesAPIDemo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )