[pull] main from expo:main #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alMemberExpression`s (#42752) # Why Resolves #42296 (See comment: #42296 (comment)) Resolves #41334 I believe this has come up across a few issues, although it'll be hard to find all of them that are related. It's pretty intuitive to write `process.env?.EXPO_PUBLIC_*` and it's not intuitive for that not to be supported. The inline plugin doesn't yet have an `OptionalMemberExpression` visitor and nothing blocks us in the Babel plugin from supporting this. # How - Refactor to remove `matchesPattern` for local `isProcessEnv` check - Refactor to remove `toComputedKey` for simple `toMemberProperty` helper - Reuse `MemberExpression` visitor as `memberExpressionVisitor` for `OptionalMemberExpression` # Test Plan - Tests updated to reflect new cases # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )