[pull] main from expo:main #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on (#42556) # Why A lot of the queries in here don't change often and we'd like this to be simpler and smaller. While we can replace GraphQL Code Generator, for now, nothing is in its place for codegen. We can maybe align this with internal EAS Build tooling (e.g. `gql.tada`) in the future. For now, the GraphQL client code, currently, `urql`, should be replaced with a fetch wrapper, since we have very limited needs for it and only call this transactionally with lean retry logic and an in-memory cache in place. Invalidation wasn't really appropriate, since not many of the queries interact with one another. # How - Replace GraphQL client implementation - Drop dependencies and GCG harness # Test Plan - `user.ts` code paths tested via `expo login` and `expo whoami` - `AppQuery.byIdAsync` manually tested with modifications to `getOrPromptApplicationId.ts` (basically manual invocation), since there's a lot of preferred methods for this logic before the www fallback # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
…ith `multitars` (#42472) Supersedes #41210 # Why We'd like to gradually phase out `tar` (and later on `glob`) in `expo/expo` to prevent us having to update it when security notices are released for them, and since we have limited use for some of the edge cases handled by the CLI and extraction logic in `tar` and `glob`. This PR replaces `tar` and old `multipart/mixed` utilities in `@expo/cli` only. This logic can be cleaned up or refactored in subsequent PRs, after testing, and then applied to other relevant repositories, or extracted into a common package (`create-expo-module` and `create-expo`) We're relying on our E2E tests for prebuild, so a lot of the tests haven't changed, or didn't need to change. # How - Replace `@expo/multipart-body-parser` in tests with `multitars` - Replace `multipartMixed` utility file with `multitars` - Add extraction logic to `src/utils/tar.ts` for `multitars` - Move options from `npm.ts`, which don't belong there, to `multitars` - Rewrite function signatures for `tar.ts` and `npm.ts` # Test Plan - Existing unit tests and E2E tests are expected to pass - `expo prebuild -p ios --no-install` in `apps/router-e2e` (local and non-local) - Commenting out the `spawnAsync` tar code, running `DEBUG=expo:utils:tar expo start` and opening iOS to check if Expo Go installs correctly The `DEBUG=expo:utils:tar` shows what the tar extraction is doing # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# How * Rebuild config plugin after #42507 * Add `expo-widgets` to codemention
…nd `@expo/image-utils` and support more package managers (#42513) # Why - `requireg`, used in `@expo/cli` has a lot of redundant and inaccurate code paths and does not support pnpm or bun - `resolve-global` is accurate but also doesn't support pnpm or bun - both haven't been maintained recently and add more dependencies than necessary - both tend to read configuration files, instead of just calling `npm` directly to get the prefix # How - Implement a replacement `resolveGlobal.ts` - Add `resolveGlobal.ts` to `@expo/cli`'s `ExternalModule` implementation - Replace `resolve-global` in `@expo/image-utils`'s `sharp-cli` resolution We attempt (in order) to: - guess possible npm prefix paths - call the npm CLI with `npm config -g get prefix` to get the canonical prefix - guess possible yarn prefix paths - call the yarn CLI with `yarn global dir` to get the canonical prefix path - call the pnpm CLI with `pnpm root -g` to get the global `node_modules` folder - call Bun with `bun pm bin -g` and: - treat the directory and `/global` as a prefix - resolve any installed directory to the global `node_modules` folder - We retrieve the native `node_modules` prefix paths from `Module.globalPaths` (see: https://github.com/nodejs/node/blob/7599a8bb73a50e84ca88be1fe81237fdc45e73c9/lib/internal/modules/cjs/loader.js#L1733-L1761) # Test Plan - Install a module globally with npm, use `resolveGlobal` manually in a repl, and check that it resolves to the global installation - Install a module globally with yarn, use `resolveGlobal` manually in a repl, and check that it resolves to the global installation - Install a module globally with pnpm, use `resolveGlobal` manually in a repl, and check that it resolves to the global installation - Install a module globally with bun, use `resolveGlobal` manually in a repl, and check that it resolves to the global installation # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why To start live activity remotely, we need to obtain device push-to-start token. # How Added `onPushToStartTokenReceived` event based on https://github.com/software-mansion-labs/expo-live-activity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )