[pull] main from expo:main #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why
This PR adds the ability to control the Apple Maps appearance
(light/dark mode) independently from the app's color scheme.
Currently, the map follows the system/app appearance automatically.
However, there are use cases where developers want to force a specific
appearance for the map regardless of the app's theme - for example,
displaying a light map in a dark-themed app for better visibility, or
vice versa.
This addresses a common request for more granular control over map
styling.
# How
Added a new `colorScheme` prop to `AppleMaps.View` with three options:
- `AUTOMATIC` (default) - Map follows the system's color scheme
- `LIGHT` - Map is always displayed in light mode
- `DARK` - Map is always displayed in dark mode
# Test Plan
1. Add `userInterfaceStyle` prop to an `AppleMaps.View`:
```tsx
import { AppleMaps } from 'expo-maps';
<AppleMaps.View
style={{ flex: 1 }}
colorScheme={AppleMaps.MapColorScheme.DARK}
cameraPosition={{
coordinates: { latitude: 37.7749, longitude: -122.4194 },
zoom: 12,
}}
/>
```
2. Test each value:
- `AUTOMATIC` - Map should follow app appearance
- `LIGHT` - Map should always be light, even when app/system is in dark
mode
- `DARK` - Map should always be dark, even when app/system is in light
mode
3. Verify that the rest of the app's UI is not affected by the map's
`colorScheme` setting.
# Checklist
- [x] I added a `changelog.md` entry and rebuilt the package sources
according to [this short
guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting)
- [x] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
- [x] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
Co-authored-by: Kadi Kraman <kadi@expo.io>
# Why Closes ENG-18974 # How Use new api to set `onboardingAppName` # Test Plan <img width="450" height="978" alt="Simulator Screenshot - iPhone 17 Pro - 2026-01-27 at 10 52 40" src="https://github.com/user-attachments/assets/83be3db0-89a0-47b6-b6c2-50e55f15dd23" />
# Why Closes ENG-18979 Make source code editable in the explorer. # How This is only an in-memory edit and does not persist once you leave the screen. # Test Plan Expo go
# Why Moves the connection info lower in the menu. # Test Plan Bare expo <img width="450" height="978" alt="simulator_screenshot_39EEF5B3-56FC-4838-8A7B-CF3FDDF23C7D" src="https://github.com/user-attachments/assets/9ede5649-8f05-4022-9aec-894d8bfc7edc" />
# Why Moves the connection info lower in the menu. # Test Plan Bare expo <img width="450" height="1010" alt="Screenshot_1769455531" src="https://github.com/user-attachments/assets/ffb183f5-9f1a-4f29-ade6-94a2ee1eb396" />
jest-expo@55.0.5 expo-widgets@55.0.0-alpha.4 expo-symbols@55.0.3 expo-sharing@55.0.4 expo-sensors@55.0.3 expo-screen-orientation@55.0.3 expo-screen-capture@55.0.3 expo-router@55.0.0-beta.4 expo-modules-core@55.0.5 expo-module-template@55.0.4 expo-media-library@55.0.3 expo-maps@55.0.3 expo-localization@55.0.3 expo-image@55.0.3 expo-font@55.0.3 expo-dev-menu-interface@55.0.1 expo-dev-menu@55.0.3 expo-dev-launcher@55.0.4 expo-crypto@55.0.3 expo-clipboard@55.0.3 expo-build-properties@55.0.4 expo-brownfield@55.0.4 expo@55.0.0-preview.7 @expo/router-server@55.0.3 @expo/log-box@55.0.3 @expo/cli@55.0.4 expo-template-default@55.1.1 expo-file-system@55.0.3 @expo/metro-runtime@55.0.3 expo-sqlite@55.0.3 expo-splash-screen@55.0.3 expo-web-browser@55.0.3 expo-glass-effect@55.0.3 expo-system-ui@55.0.3 expo-task-manager@55.0.3 expo-application@55.0.3 @expo/ui@55.0.0-beta.3 expo-manifests@55.0.3 expo-gl@55.0.3 expo-template-tabs@55.1.1 expo-template-blank@55.1.1 expo-template-bare-minimum@55.0.6 expo-template-blank-typescript@55.1.1 patch-project@55.1.1 expo-background-task@55.0.3 expo-background-fetch@55.0.3 expo-auth-session@55.0.3 expo-video@55.0.3 expo-video-thumbnails@55.0.3 expo-updates@55.0.5 expo-insights@55.0.4 expo-dev-client@55.0.3 expo-tracking-transparency@55.0.3 expo-store-review@55.0.3 expo-standard-web-crypto@55.0.3 expo-speech@55.0.3 expo-sms@55.0.3 expo-secure-store@55.0.3 expo-processing@55.0.3 expo-print@55.0.3 expo-notifications@55.0.4 expo-network-addons@55.0.3 expo-network@55.0.3 expo-navigation-bar@55.0.3 expo-mesh-gradient@55.0.3 expo-mail-composer@55.0.3 expo-location@55.0.4 expo-local-authentication@55.0.3 expo-live-photo@55.0.3 expo-linear-gradient@55.0.3 expo-image-picker@55.0.3 expo-image-manipulator@55.0.3 expo-haptics@55.0.3 expo-intent-launcher@55.0.3 expo-document-picker@55.0.3 expo-doctor@1.18.3 expo-device@55.0.3 expo-contacts@55.0.3 expo-cellular@55.0.3 expo-camera@55.0.3 expo-calendar@55.0.3 expo-brightness@55.0.3 expo-blur@55.0.3 expo-battery@55.0.3 expo-blob@55.0.3 expo-audio@55.0.3 expo-apple-authentication@55.0.3 @expo/app-integrity@55.0.3 expo-age-range@0.2.5
#42563) # Why This has been previously fixed in #39481, back when FAB was separate for Expo Go and didn't support Quest in dev-client builds. The FAB doesn't respond to press events on Quest, also in Expo Go on refresh the activity gets restarted, because of this the refresh is very sudden and jarring. # How - Don't consume the press event - Wait for the spin animation to (almost) finish, thanks to that the user gets a visual feedback that the refresh is coming # Test Plan Tested in Expo Go and BareExpo on a Quest device and Pixel 8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )