[pull] main from expo:main #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why Adds docs for the new functionality added to `expo-sharing` # How Update `shareing.mdx` and type definitions. # Test Plan Tested in local docs
…42438) # Why With this change, there won't be a situation where, for example, we only edit a .kt file but it also runs the entire iOS workflow. # How Firstly, it uses `actions/checkout@v4` with `fetch-depth: 1000` and `filter: blob:none` to download the latest 1000 commits. This is required by `tj-actions/changed-files` because we need to calculate the diff between the main branch and the last commit. Then it uses `files_yaml` to classify whether changes affect iOS, Android, or both. I analyzed all extensions in the repository and came to the conclusion that only `.md`, `LICENSE`, `.gitignore`, `CHANGELOG`, `.npmignore`, `.eslintrc`, `gitattributes`, `.fingerprintignore`, `.watchmanconfig`, `.prettierrc` can be safely ignored. # Performance implications This job takes around ~20s. It's a downside when we make PRs that affect both platforms, but on the other hand when the change is platform-specific it saves time and CI resources. # Test Plan Run the workflow using a stacked PR with different changes that trigger each logical state of the outputs. I wrote a [test script ](https://github.com/user-attachments/files/24820714/v3.js) that uses micromatch (the pattern matching library in `tj-actions/changes-files`). It analyzes all files in the repository and creates JSON files which tell which E2E tests will run. Both: [trigger_both.json](https://github.com/user-attachments/files/24820652/trigger_both.json) Only Android: [trigger_android.json](https://github.com/user-attachments/files/24820645/trigger_android.json) Only iOS: [trigger_ios.json](https://github.com/user-attachments/files/24820660/trigger_ios.json) None: [ignored.json](https://github.com/user-attachments/files/24820661/ignored.json)
# Why To allow us to land #42449 again we need to update Expo Go to support internal importing Expo modules # How Enable swift Internal import by default in Expo Go's Xcode project and remove the explicit `public` declaration from classes that inherited from ExpoModuels # Test Plan Run Expo Go locally after cherry picking a047cf3 # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
…job (#42528) # Why The `github-comment` workflow job now supports auto-discovery of EAS Hosting deployments, but the documentation doesn't reflect this new capability. Closes ENG-18932 # How - Update `github-comment` documentation to include deployments alongside builds and updates - Add `deployment_ids` parameter to the syntax reference - Add "PR preview with EAS Hosting deployment" example - Simplify the PR preview example in hosting/workflows.mdx by removing manual `message` parameter - Update syntax.mdx to match # Test Plan - Verified locally by running `yarn dev` # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) Signed-off-by: Ash Wu <hsatac@gmail.com>
…source qualifiers (#40901)
# Why Quest can return to the app without doing a valid action in the browser (such as cancelling the login or logging in). Because of this our current logic, which relies on `onResume` event, fails on Quest. # How On Quest, do not rely on `onResume` event to determine the login cancellation. Instead, during login display a loading screen, where the user has to manually press a button to cancel the request. The loading screen is enabled for all devices but visible only on Quest, since all other supported platforms have proper Custom Tabs support. # Test Plan Tested in Quest and a regular phone https://github.com/user-attachments/assets/5f854619-8d0c-4383-b292-9786b05ac97b
# Why FAB should be always enabled on Quest devices # How Hide the toggle if `VRUtilities.isQuest` is `true` # Test Plan Tested in ExpoGo on a Meta Quest and a Pixel 8
# Why The Floating Action Button should always be enabled on Quest devices, because it is the only device-level way to open the dev menu. # How Make the button on by default and remove options to disable it for Quest devices. # Test Plan Tested on a Meta Quest device and a Pixel 8
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Tomasz Sapeta <tsapeta@expo.dev>
…cribe more common problems (#42586) # Why <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How <!-- How did you build this feature or fix this bug and why? --> # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )