[pull] main from expo:main #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why There were a few missing cases from previous loader PRs that needed addressing. Additionally, there were some opportunities to tidy things up in the Jest E2E tests. # How - Added Suspense handling to loader E2E fixture - Added missing test cases to Jest E2E tests - Created a new `getPageAndLoaderData()` helper to ensure the HTML output and loader JSON are aligned - Added test cases for: - environment variable support - immutable requests - proper 404 behavior - `setResponseHeaders()` support - `<Head>` support - error handling - Modified dev server Playwright tests to run in both static and server rendering mode - Removed unnecessary test cases from Playwright # Test Plan - CI # Checklist - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Jakub Tkacz <32908614+Ubax@users.noreply.github.com>
…mes V1 (#42477) # Why Using Hermes V1 requires users to set a yarn resolution to use hermes-compiler 250829098.0.4. To prevent confusion around uses trying to enable this option, we should validate the hermes-compiler version when enabling hermes V1. # How Add hermes-compiler version validation to expo-build-properties when enabling hermes V1 # Test Plan Enable hermesV1 and run `npx expo prebuild` locally # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Phil Pluckthun <phil@kitten.sh>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )