[pull] main from expo:main #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ast socket to local connections (#42538) # Why Reverts part of #42156 for `expo-dev-plugins` and only leaves behind a conditional `Origin` check since the broadcast socket doesn't differentiate between the Web UI and clients. Must be backported to the same branches (`sdk-54`, `sdk-53`, `sdk-52`) # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
…#41910) # Why When I was trying to configure the new `expo/local-build-cache-provider`, no error messages about missing `@expo/fingerprint` were displayed during the build. # How Replace `debug` with `Log.warn` and specify that it comes from the build cache. # Test Plan Replace the code inside node_modules and run `bun ios`. # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
) # Why Fixes #42474 When building react-native from sources, `React-Core` and `React-RCTFabric` fails to compile as `UIApplication sharedApplication` (used in `RCTScrollView`) is not available in widget extension. # How We can safely ignore this, as this part can't be executed in widget anyway, so we set `'APPLICATION_EXTENSION_API_ONLY' = 'NO'`
# Why This change introduces the term "channel surfing" to describe switching update channels at runtime. It also adds a sub-section about risks of considerations with channel surfing. # How - Adjusted the original section of the "Override request headers"-section to introduce the term channel surfing - Added a sub-section about Risk and considerations. # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why This PR adds deprecation notices to `removeSubscription` methods across several Expo packages. These methods are deprecated in favor of using `subscription.remove()` directly. Other packages already use this pattern. # How Added `@deprecated use subscription.remove() instead` JSDoc comments to the `removeSubscription` methods in: - `expo-localization` - `expo-media-library` - `expo-sensors` - `removeClipboardListener` in `expo-clipboard` # Test Plan Verified that the deprecation notices appear in the TypeScript definitions and JavaScript files after rebuilding the packages. # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why This PR marks the `removeOrientationChangeListeners` and `removeOrientationChangeListener` functions as deprecated in the expo-screen-orientation package. These functions will be removed in future versions. related to https://app.graphite.com/github/pr/expo/expo/42098/mark-removeSubscription-calls-as-deprecated but shipped as a separate PR as this one is a bit different than the rest # How Added `@deprecated` JSDoc tags to both functions with appropriate messages: - For `removeOrientationChangeListeners`: "this function will be removed in future versions. Keep track of your own subscriptions." - For `removeOrientationChangeListener`: "this function will be removed in a future version. Use `subscription.remove()` instead." # Test Plan The changes are purely documentation-related. The TypeScript definitions and JavaScript files have been updated with the deprecation notices, which will show up in IDEs and documentation. # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )