Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/brave-geckos-juggle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"wrangler": patch
---

fix: improve error message when the entrypoint is incorrect

Error messages for incorrect entrypoint configuration have been improved to provide clearer and more actionable feedback. The updated messages help users understand what went wrong and how to fix their configuration.
9 changes: 9 additions & 0 deletions .changeset/deep-fans-guess.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@cloudflare/devprod-status-bot": minor
---

Send alert to ANT: Alerts chat on failed CI checks in Version Packages PRs

When a required CI check fails or times out on the Version Packages PR (`changeset-release/main` branch), an alert is now sent to the ANT: Alerts Google Chat channel. This helps the team quickly identify and address CI failures that shouldn't occur since individual PRs have already passed before landing on main.

Alerts for the same PR are grouped into the same chat thread using the PR number as the thread ID.
7 changes: 7 additions & 0 deletions .changeset/redact-email-non-interactive.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"wrangler": patch
---

fix: redact email addresses and account names in non-interactive mode

To prevent sensitive information from being exposed in public CI logs, email addresses and account names are now redacted when running in non-interactive mode (e.g., CI environments). Account IDs remain visible to aid debugging.
34 changes: 12 additions & 22 deletions fixtures/get-platform-proxy/tests/get-platform-proxy.caches.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,18 @@ describe("getPlatformProxy - caches", () => {
cacheType === "default"
? caches.default
: await caches.open("my-cache");
testNoOpCache(cache);

let match = await cache.match("http://0.0.0.0/test");
expect(match).toBeUndefined();

const req = new Request("http://0.0.0.0/test");
await cache.put(req, new Response("test"));

const resp = await cache.match(req);
expect(resp).toBeUndefined();

const deleted = await cache.delete(req);
expect(deleted).toBe(false);
} finally {
await dispose();
}
Expand Down Expand Up @@ -58,24 +69,3 @@ describe("getPlatformProxy - caches", () => {
}
});
});

async function testNoOpCache(
cache: Awaited<ReturnType<typeof getPlatformProxy>>["caches"]["default"]
) {
let match = await cache.match("http://0.0.0.0/test");
// Note: we cannot use expect here since it's not in the test context
if (match !== undefined) {
throw new Error("Expected match to be undefined");
}

const req = new Request("http://0.0.0.0/test");
await cache.put(req, new Response("test"));
const resp = await cache.match(req);
if (resp !== undefined) {
throw new Error("Expected resp to be undefined");
}
const deleted = await cache.delete(req);
if (deleted !== false) {
throw new Error("Expected deleted to be false");
}
}
7 changes: 3 additions & 4 deletions fixtures/start-worker-node-test/src/config-errors.test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import assert from "node:assert";
import test, { describe } from "node:test";
import { setTimeout } from "node:timers/promises";
import getPort from "get-port";
import { unstable_startWorker } from "wrangler";

Expand All @@ -20,7 +19,7 @@ describe("startWorker - configuration errors", () => {
assert(cause instanceof Error);
assert.match(
cause.message,
/The entry-point file at "not a real entrypoint" was not found./
/The entry-point file at "not a real entrypoint" was not found\./
);
return true;
}
Expand Down Expand Up @@ -88,9 +87,9 @@ describe("startWorker - configuration errors", () => {
worker.setConfig({ entrypoint: "not a real entrypoint" }, true),
(err) => {
assert(err instanceof Error);
assert.strictEqual(
assert.match(
err.message,
'The entry-point file at "not a real entrypoint" was not found.'
/The entry-point file at "not a real entrypoint" was not found\./
);
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ it("dispatches fetch event", { timeout: 10_000 }, async ({ expect }) => {
Call /lb to test load balancing"
`);
// however if you attempt to start a container, you should expect an error
await expect(() =>
await expect(
SELF.fetch("http://example.com/container/hello")
).rejects.toThrow();
});
2 changes: 1 addition & 1 deletion fixtures/workflow/tests/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ describe("Workflows", () => {
}) => {
const name = randomUUID();
await fetchJson(
`http://${ip}:${port}/createDemo3?workflowName=${name}&doRetry=false&errorMessage=generic_error_message"`
`http://${ip}:${port}/createDemo3?workflowName=${name}&doRetry=false&errorMessage=generic_error_message`
);

await vi.waitFor(
Expand Down
Loading
Loading