Skip to content

[pull] main from withastro:main #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Jan 21, 2026
Merged

[pull] main from withastro:main #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/add-favicon-ico-fallbacks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'astro': patch
---

Adds `.ico` favicon fallbacks to all examples to ensure correct indexing in Google Search results

Previously, some official examples used only SVG favicons. While supported by modern browsers, this caused issues with Google Search's crawler, which may fail to display favicons for sites without a standard `.ico` fallback. This change adds a `favicon.ico` file to the `public/` directory and includes an explicit `<link rel="icon" href="/favicon.ico" />` tag to improve cross-browser and crawler compatibility.
Binary file added examples/basics/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/basics/src/layouts/Layout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<meta name="generator" content={Astro.generator} />
<title>Astro Basics</title>
</head>
Expand Down
Binary file added examples/blog/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/blog/src/components/BaseHead.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const { title, description, image = FallbackImage } = Astro.props;
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width,initial-scale=1" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<link rel="sitemap" href="/sitemap-index.xml" />
<link
rel="alternate"
Expand Down
Binary file added examples/container-with-vitest/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/container-with-vitest/src/pages/[locale].astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const { locale } = Astro.params;
<head>
<meta charset="utf-8" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<meta name="viewport" content="width=device-width" />
<meta name="generator" content={Astro.generator} />
<title>Astro</title>
Expand Down
1 change: 1 addition & 0 deletions examples/container-with-vitest/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<head>
<meta charset="utf-8" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<meta name="viewport" content="width=device-width" />
<meta name="generator" content={Astro.generator} />
<title>Astro</title>
Expand Down
Binary file added examples/framework-alpine/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/framework-alpine/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import Counter from '../components/Counter.astro';
<meta name="viewport" content="width=device-width" />
<meta name="generator" content={Astro.generator} />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<style>
html,
body {
Expand Down
Binary file added examples/framework-multiple/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/framework-multiple/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import VueCounter from '../components/vue/VueCounter.vue';
<meta name="viewport" content="width=device-width" />
<meta name="generator" content={Astro.generator} />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
</head>
<body>
<main>
Expand Down
Binary file added examples/framework-preact/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/framework-preact/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const count = signal(0);
<meta name="viewport" content="width=device-width" />
<meta name="generator" content={Astro.generator} />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<style>
html,
body {
Expand Down
Binary file added examples/framework-react/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/framework-react/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const someProps = {
<meta name="viewport" content="width=device-width" />
<meta name="generator" content={Astro.generator} />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<style>
html,
body {
Expand Down
Binary file added examples/framework-solid/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/framework-solid/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import Counter from '../components/Counter';
<meta name="viewport" content="width=device-width" />
<meta name="generator" content={Astro.generator} />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<style>
html,
body {
Expand Down
Binary file added examples/framework-svelte/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/framework-svelte/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import Counter from '../components/Counter.svelte';
<meta name="viewport" content="width=device-width" />
<meta name="generator" content={Astro.generator} />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<style>
html,
body {
Expand Down
Binary file added examples/framework-vue/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/framework-vue/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import Counter from '../components/Counter.vue';
<meta name="viewport" content="width=device-width" />
<meta name="generator" content={Astro.generator} />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<style>
html,
body {
Expand Down
Binary file added examples/hackernews/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/hackernews/src/layouts/Layout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import Nav from '../components/Nav.astro';
<head>
<meta charset="utf-8" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="generator" content={Astro.generator} />
<title>Astro - Hacker News</title>
Expand Down
Binary file added examples/minimal/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/minimal/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<head>
<meta charset="utf-8" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<meta name="viewport" content="width=device-width" />
<meta name="generator" content={Astro.generator} />
<title>Astro</title>
Expand Down
Binary file added examples/portfolio/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/portfolio/src/components/MainHead.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ const {
<title>{title}</title>

<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<link rel="preconnect" href="https://fonts.googleapis.com" />
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin />
<link
Expand Down
Binary file added examples/ssr/public/favicon.ico
View file
Open in desktop
Binary file not shown.
Binary file added examples/starlog/public/favicon.ico
View file
Open in desktop
Binary file not shown.
Binary file added examples/with-markdoc/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/with-markdoc/src/layouts/Layout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const { title } = Astro.props;
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<meta name="generator" content={Astro.generator} />
<title>{title}</title>
</head>
Expand Down
Binary file added examples/with-mdx/public/favicon.ico
View file
Open in desktop
Binary file not shown.
Binary file added examples/with-nanostores/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/with-nanostores/src/layouts/Layout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const { title } = Astro.props;
<meta name="viewport" content="width=device-width" />
<meta name="generator" content={Astro.generator} />
<link rel="icon" type="image/svg+xml" href={withBase('/favicon.svg')} />
<link rel="icon" href={withBase('/favicon.ico')} />
<title>{title}</title>
</head>
<body>
Expand Down
Binary file added examples/with-tailwindcss/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/with-tailwindcss/src/layouts/main.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const { content } = Astro.props;
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<title>{content.title}</title>
</head>
<body>
Expand Down
1 change: 1 addition & 0 deletions examples/with-tailwindcss/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import Button from '../components/Button.astro';
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<meta name="generator" content={Astro.generator} />
<title>Astro + TailwindCSS</title>
</head>
Expand Down
Binary file added examples/with-vitest/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions examples/with-vitest/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<head>
<meta charset="utf-8" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" href="/favicon.ico" />
<meta name="viewport" content="width=device-width" />
<meta name="generator" content={Astro.generator} />
<title>Astro</title>
Expand Down
Loading