[pull] main from withastro:main #328
Merged
+319
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(css): include styles for conditionally rendered Svelte 5 components
When Svelte 5 components are conditionally rendered (e.g., inside {#if} blocks
with an initially false condition), their styles were not being included in
production builds. This happened because:
1. Svelte 5.26+ added css.hasGlobal flag to compiler output
2. vite-plugin-svelte 5.1.0+ uses this to add cssScopeTo metadata
3. Vite 6.2+ cssScopeTo allows CSS treeshaking if the export isn't "used"
During SSR, conditionally rendered components aren't included in the server
build (tree-shaken), but they are in the client build. Astro's CSS-to-page
mapping primarily happens during the server build, so the CSS gets orphaned.
The fix adds logic in the client build's generateBundle to:
- Track which component exports are actually rendered (renderedComponentExports)
- For CSS modules with cssScopeTo metadata where the export IS rendered,
walk up the module graph to find pages and ensure the CSS is included
Fixes #14252
* Track components from server pages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )