[pull] main from withastro:main #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(css): prevent double-bundling when CSS imported from multiple locations Fixes #14991 When CSS was imported in both a page's frontmatter and a component's script tag, it was bundled twice in production builds. This happened because the CSS plugins run for both SSR and client builds, adding CSS to the same pageData.styles array. The fix adds content-based deduplication that checks existing styles before adding new ones - comparing by content for inline CSS and by src for external CSS. * chore: update pnpm-lock.yaml for new test fixture --------- Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
) * test: add failing case for url imports * fix: files added to chunks are not orphaned * docs: add comment explaining updated orphaned logic * docs: add changeset * fix: only check importedAssets * test: add case for ?url&no-inline import * Revert "Revert "fix(build): Prevent duplicate CSS for hydrated client components" (#14612)" This reverts commit 18552c7. * docs: update changeset * docs: update changeset * fix: lockfile --------- Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )