[pull] main from withastro:main #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(css): rewrite absolute URLs with base path in dev mode Fixes CSS url() references to public assets returning 404 in dev mode when base path is configured. Applies URL rewriting after preprocessCSS() using Vite's cssUrlRE regex pattern. Closes #14585 * fix linting error * add changeset * fix spelling in changeset * Update packages/astro/test/units/compile/css-base-path.test.js * fix: experimental --------- Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev> Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
* feat(sitemap): add chunking strategy for sitemaps Adds the ability to split sitemap generation into chunks based on customizable logic. This allows for better management of large sitemaps and improved performance. The new `chunks` option in the sitemap configuration allows users to define functions that categorize sitemap items into different chunks. Each chunk is then written to a separate sitemap file. This change introduces a new `writeSitemapChunk` function to handle the writing of individual sitemap chunks. * feat(sitemap): add chunks option to sitemap config Adds a `chunks` option to the sitemap configuration schema. This allows users to define custom chunking strategies for generating sitemaps, providing flexibility in how the sitemap is split into multiple files. * feat(sitemap): add sitemap chunk writing functionality * fix(sitemap): fix empty callback in writeSitemap The empty callback function in the `writeSitemap` function was causing unnecessary function calls. This commit fixes this by removing the empty callback. * feat(sitemap): add test fixture for sitemap chunking This commit adds a test fixture to verify the sitemap chunking functionality. It includes a configuration file, dependencies, and several pages to simulate a real-world scenario. * test(sitemap): add test for sitemap chunking with files * feat(sitemap): add changeset for sitemap chunking Adds changeset to document the new sitemap chunking feature. This feature allows splitting sitemap generation into chunks based on customizable logic, improving management of large sitemaps and performance. * build: update dependencies and add astro * chore: remove unused astro dependency * chore: remove unused entries from lockfile * refactor(sitemap): improve import ordering and formatting * refactor(sitemap): improve import ordering The import order of `AstroConfig` has been moved to align with other imports, improving code readability and consistency. This change ensures that type imports are grouped together, making the codebase easier to maintain. * refactor(sitemap): improve import ordering * refactor(sitemap): improve import ordering * refactor(sitemap): improve import ordering * refactor(sitemap): improve chunk file test readability Simplify the chunk file test by using `path.resolve` and `includes` for better readability and maintainability. This change improves the test's clarity without altering its functionality. * test(sitemap): fix flaky chunk file tests The tests were failing intermittently because the `readXML` function was not properly resolving the file path. This commit updates the `readXML` function to use `fixture.readFile` to ensure that the file path is resolved correctly. Additionally, the `flatMapUrls` function is now async to ensure that the `readXML` function is awaited. * refactor(sitemap): improve import ordering * Update .changeset/floppy-times-grab.md Co-authored-by: Matt Kane <m@mk.gg> * chore(sitemap): update changeset to minor The previous changeset incorrectly marked the sitemap chunking feature as a major change. This commit corrects the changeset to reflect that it is a minor feature addition. * feat(sitemap): add chunking support for sitemap generation * fix: attempt to fix lockfile * fix: conflict * fix: lockfile --------- Co-authored-by: Matt Kane <m@mk.gg> Co-authored-by: Princesseuh <3019731+Princesseuh@users.noreply.github.com>
* fix: update outdated links to Astro Docs * some were correctly redirected, but might as well use the new links * some used the right page, but the section has been renamed or removed * some were no longer targeting the correct page * docs: add changeset
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )