Skip to content

[pull] main from chakra-ui:main #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Jan 30, 2026
Merged

[pull] main from chakra-ui:main #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
582d23a
fix: typecheck
segunadebayo Jan 30, 2026
1a826d2
test: rm skip
segunadebayo Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/src/components/file-upload/tests/file-upload.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { axe } from 'vitest-axe'
import { ComponentUnderTest, FileUploadWithField } from './basic'

describe('File Upload', () => {
it.skip('should have no a11y violations', async () => {
it('should have no a11y violations', async () => {
const { container } = await act(async () => render(<ComponentUnderTest />))
const results = await axe(container)

Expand Down
5 changes: 3 additions & 2 deletions packages/vue/src/components/date-picker/examples/with-time.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ const formattedValue = computed(() => {
return v ? formatter.format(v.toDate(getLocalTimeZone())) : 'Select date and time'
})

const onTimeChange = (e: Event & { currentTarget: HTMLInputElement }) => {
const [hours, minutes] = e.currentTarget.value.split(':').map(Number)
const onTimeChange = (e: Event) => {
const target = e.target as HTMLInputElement
const [hours, minutes] = target.value.split(':').map(Number)
const current = value.value[0] ?? new CalendarDateTime(2025, 1, 1, 0, 0)
value.value = [current.set({ hour: hours, minute: minutes })]
}
Expand Down