[pull] latest from ag-grid:latest #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* AG-16620 - [formulas] - docs restructure * Apply suggestion from @StephenCooper --------- Co-authored-by: Stephen Cooper <scooperdev@gmail.com>
* AG-16639 Be more explicit about pending values * Add getCellValue api to docs
… deletes unrelated rows (#12923) * Add test to verify repeated remove transaction does not affect unrelated rows - Add test case to ensure applying remove transaction multiple times does not corrupt store or delete unrelated rows - Verify that removing the same rows twice does not impact displayed row count or data integrity - Confirm that after repeated remove operations, only expected rows are removed and remaining rows remain unchanged Fixes AG-16019 * Add error message for ignored rows in server-side remove transaction Fixes AG-16019 * Add remove transaction warnings and verify behavior Fixes #AG-16019 * Update error message for ignored rows in remove transaction to handle large ID lists * Add test to verify repeated remove transaction does not corrupt store or delete unrelated rows - Add test case to ensure applying remove transaction multiple times does not corrupt store or delete unrelated rows - Verify that removing the same rows twice does not impact displayed row count or data integrity - Confirm that after repeated remove operations, only expected rows are removed and remaining rows remain unchanged Fixes AG-16019 * Apply suggestion from @sdwvit * lint * Apply suggestion from @sdwvit * remove warn and other cleanup * update test * update doc * Add support for `rowCount` in server-side transaction - Introduce `rowCount` field in `ServerSideTransaction` interface to allow setting total row count - Update `LazyStore` to trust and apply `rowCount` from transaction if provided - Ensure `rowCount` is only applied when valid (>= 0) to prevent invalid state - Maintain data integrity during repeated remove transactions Fixes AG-16019 * Update `removeRowNodes` to accept `rowCount` and fix row count adjustment logic - Modify `removeRowNodes` to accept `newRowCount` parameter to ensure accurate row count adjustment - Update row count calculation to use `removedNodes.length` instead of `idsToRemove.length` for correctness - Ensure `isLastRowKnown` is updated based on `newRowCount` validity - Handle `remainingIdsToRemove` and `nodesToVerify` conditions after row count adjustment - Remove redundant `deletedNodeCount` variable and simplify logic Fixes AG-16019 * Update `ServerSideTransaction` interface documentation for `rowCount` field * update comment * refactor logic a bit * add comment * move doc around * pr comment * revert some change * update tests
…demo page (#13003) * bring back video tour and also adjust styles to use media query Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * centre content vertically Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> * update Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> --------- Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )