Conversation
* Re-register run_in_terminal tool when sandbox settings change When the terminal sandbox setting is toggled at runtime, the run_in_terminal tool's schema and description were not updated because the tool data was only computed once at startup. This meant the model never learned about requestUnsandboxedExecution when sandbox was enabled after startup. Fix by using a MutableDisposable to manage the tool registration and re-registering whenever sandbox-related settings, network domains, or trusted domains change. Fixes #303714 * Fix race condition in run_in_terminal tool re-registration and add refresh tests Guard _registerRunInTerminalTool against stale async resolutions using a monotonically increasing version counter. Export ChatAgentToolsContribution for testability. Add integration tests verifying tool data refreshes on config and trusted domain changes.
…ega/steady-puma
Sessions: E2E test fixes
Add per-invocation icon support to tool invocations via `IPreparedToolInvocation.icon` and `IChatToolInvocation.icon`. The terminal tool sets the icon to `terminal-secure` when sandbox is active, or `terminal` otherwise. The thinking content part and subagent content part use this icon when rendering, falling back to the existing heuristic for tools without a registered icon. Also removes the $(lock) theme icon prefix from sandbox invocation messages since the icon now communicates the sandbox state.
* Adopt new codicons version * terminal: use terminal-secure codicon for sandboxed commands Add per-invocation icon support to tool invocations via `IPreparedToolInvocation.icon` and `IChatToolInvocation.icon`. The terminal tool sets the icon to `terminal-secure` when sandbox is active, or `terminal` otherwise. The thinking content part and subagent content part use this icon when rendering, falling back to the existing heuristic for tools without a registered icon. Also removes the $(lock) theme icon prefix from sandbox invocation messages since the icon now communicates the sandbox state. * Fix unit test * Review feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )