[pull] main from microsoft:main

extensions/git/src/diagnostics.ts

@@ -85,7 +85,11 @@ export class GitCommitInputBoxDiagnosticsManager {
 			const threshold = index === 0 ? inputValidationSubjectLength ?? inputValidationLength : inputValidationLength;
 
 			if (line.text.length > threshold) {
-				const diagnostic = new Diagnostic(line.range, l10n.t('{0} characters over {1} in current line', line.text.length - threshold, threshold), this.severity);
+				const charactersOver = line.text.length - threshold;
+				const lineLengthMessage = charactersOver === 1
+					? l10n.t('{0} character over {1} in current line', charactersOver, threshold)
+					: l10n.t('{0} characters over {1} in current line', charactersOver, threshold);
+				const diagnostic = new Diagnostic(line.range, lineLengthMessage, this.severity);
 				diagnostic.code = DiagnosticCodes.line_length;
 
 				diagnostics.push(diagnostic);

src/vs/base/browser/ui/hover/hoverWidget.css

@@ -139,6 +139,7 @@
 .monaco-hover .hover-row.status-bar .actions .action-container .action .icon {
 	padding-right: 4px;
 	vertical-align: middle;
+	font-size: inherit;
 }
 
 .monaco-hover .hover-row.status-bar .actions .action-container a {

src/vs/base/browser/ui/tree/asyncDataTree.ts

@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { IDragAndDropData } from '../../dnd.js';
-import { IIdentityProvider, IKeyboardNavigationLabelProvider, IListDragAndDrop, IListDragOverReaction, IListMouseEvent, IListTouchEvent, IListVirtualDelegate } from '../list/list.js';
+import { IIdentityProvider, IKeyboardNavigationLabelProvider, IListDragAndDrop, IListDragOverReaction, IListMouseEvent, IListTouchEvent, IListVirtualDelegate, NotSelectableGroupIdType } from '../list/list.js';
 import { ElementsDragAndDropData, ListViewTargetSector } from '../list/listView.js';
 import { IListStyles } from '../list/listWidget.js';
 import { ComposedTreeDelegate, TreeFindMode, IAbstractTreeOptions, IAbstractTreeOptionsUpdate, TreeFindMatchType, AbstractTreePart, LabelFuzzyScore, FindFilter, FindController, ITreeFindToggleChangeEvent, IFindControllerOptions, IStickyScrollDelegate, AbstractTree } from './abstractTree.js';
@@ -1309,7 +1309,10 @@ export class AsyncDataTree<TInput, T, TFilterData = void> implements IDisposable
 			diffIdentityProvider: options.diffIdentityProvider && {
 				getId(node: IAsyncDataTreeNode<TInput, T>): { toString(): string } {
 					return options.diffIdentityProvider!.getId(node.element as T);
-				}
+				},
+				getGroupId: options.diffIdentityProvider!.getGroupId ? (node: IAsyncDataTreeNode<TInput, T>): number | NotSelectableGroupIdType => {
+					return options.diffIdentityProvider!.getGroupId!(node.element as T);
+				} : undefined
 			}
 		};
 

src/vs/base/browser/ui/tree/compressedObjectTreeModel.ts

@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { IIdentityProvider } from '../list/list.js';
+import { IIdentityProvider, NotSelectableGroupIdType } from '../list/list.js';
 import { getVisibleState, IIndexTreeModelSpliceOptions, isFilterResult } from './indexTreeModel.js';
 import { IObjectTreeModel, IObjectTreeModelOptions, IObjectTreeModelSetChildrenOptions, ObjectTreeModel } from './objectTreeModel.js';
 import { ICollapseStateChangeEvent, IObjectTreeElement, ITreeListSpliceData, ITreeModel, ITreeModelSpliceEvent, ITreeNode, TreeError, TreeFilterResult, TreeVisibility, WeakMapper } from './tree.js';
@@ -113,7 +113,10 @@ interface ICompressedObjectTreeModelOptions<T, TFilterData> extends IObjectTreeM
 const wrapIdentityProvider = <T>(base: IIdentityProvider<T>): IIdentityProvider<ICompressedTreeNode<T>> => ({
 	getId(node) {
 		return node.elements.map(e => base.getId(e).toString()).join('\0');
-	}
+	},
+	getGroupId: base.getGroupId ? (node: ICompressedTreeNode<T>): number | NotSelectableGroupIdType => {
+		return base.getGroupId!(node.elements[node.elements.length - 1]);
+	} : undefined
 });
 
 // Exported only for test reasons, do not use directly
@@ -380,7 +383,10 @@ function mapOptions<T, TFilterData>(compressedNodeUnwrapper: CompressedNodeUnwra
 		identityProvider: options.identityProvider && {
 			getId(node: ICompressedTreeNode<T>): { toString(): string } {
 				return options.identityProvider!.getId(compressedNodeUnwrapper(node));
-			}
+			},
+			getGroupId: options.identityProvider!.getGroupId ? (node: ICompressedTreeNode<T>): number | NotSelectableGroupIdType => {
+				return options.identityProvider!.getGroupId!(compressedNodeUnwrapper(node));
+			} : undefined
 		},
 		sorter: options.sorter && {
 			compare(node: ICompressedTreeNode<T>, otherNode: ICompressedTreeNode<T>): number {

src/vs/base/test/browser/ui/tree/objectTree.test.ts

@@ -8,6 +8,7 @@ import { IIdentityProvider, IListVirtualDelegate } from '../../../../browser/ui/
 import { ICompressedTreeNode } from '../../../../browser/ui/tree/compressedObjectTreeModel.js';
 import { CompressibleObjectTree, ICompressibleTreeRenderer, ObjectTree } from '../../../../browser/ui/tree/objectTree.js';
 import { ITreeNode, ITreeRenderer } from '../../../../browser/ui/tree/tree.js';
+import { runWithFakedTimers } from '../../../common/timeTravelScheduler.js';
 import { ensureNoDisposablesAreLeakedInTestSuite } from '../../../common/utils.js';
 
 function getRowsTextContent(container: HTMLElement): string[] {
@@ -16,6 +17,17 @@ function getRowsTextContent(container: HTMLElement): string[] {
 	return rows.map(row => row.querySelector('.monaco-tl-contents')!.textContent!);
 }
 
+function clickElement(element: HTMLElement, ctrlKey = false): void {
+	element.dispatchEvent(new MouseEvent('mousedown', { bubbles: true, ctrlKey, button: 0 }));
+	element.dispatchEvent(new MouseEvent('click', { bubbles: true, ctrlKey, button: 0 }));
+}
+
+function dispatchKeydown(element: HTMLElement, key: string, code: string, keyCode: number): void {
+	const keyboardEvent = new KeyboardEvent('keydown', { bubbles: true, key, code });
+	Object.defineProperty(keyboardEvent, 'keyCode', { get: () => keyCode });
+	element.dispatchEvent(keyboardEvent);
+}
+
 suite('ObjectTree', function () {
 
 	suite('TreeNavigator', function () {
@@ -231,6 +243,84 @@ suite('ObjectTree', function () {
 		tree.setChildren(null, [{ element: 100 }, { element: 101 }, { element: 102 }, { element: 103 }]);
 		assert.deepStrictEqual(tree.getFocus(), [101]);
 	});
+
+	test('updateOptions preserves wrapped identity provider in view options', function () {
+		const container = document.createElement('div');
+		container.style.width = '200px';
+		container.style.height = '200px';
+
+		const delegate = new Delegate();
+		const renderer = new Renderer();
+		const identityProvider = {
+			getId(element: number): { toString(): string } {
+				return `${element}`;
+			},
+			getGroupId(element: number): number {
+				return element % 2;
+			}
+		};
+
+		const tree = new ObjectTree<number>('test', container, delegate, [renderer], { identityProvider });
+
+		try {
+			tree.layout(200);
+			tree.setChildren(null, [{ element: 0 }, { element: 1 }, { element: 2 }, { element: 3 }]);
+
+			const firstRow = container.querySelector('.monaco-list-row[data-index="0"]') as HTMLElement;
+			const secondRow = container.querySelector('.monaco-list-row[data-index="1"]') as HTMLElement;
+			clickElement(firstRow);
+			assert.deepStrictEqual(tree.getSelection(), [0]);
+
+			tree.updateOptions({ indent: 12 });
+
+			clickElement(secondRow, true);
+
+			assert.deepStrictEqual(tree.getSelection(), [1]);
+		} finally {
+			tree.dispose();
+		}
+	});
+
+	test('updateOptions preserves wrapped accessibility provider for type navigation re-announce', async function () {
+		const container = document.createElement('div');
+		container.style.width = '200px';
+		container.style.height = '200px';
+
+		const delegate = new Delegate();
+		const renderer = new Renderer();
+		const accessibilityProvider = {
+			getAriaLabel(element: number): string {
+				assert.strictEqual(typeof element, 'number');
+				return `aria ${element}`;
+			},
+			getWidgetAriaLabel(): string {
+				return 'tree';
+			}
+		};
+
+		const tree = new ObjectTree<number>('test', container, delegate, [renderer], {
+			accessibilityProvider,
+			keyboardNavigationLabelProvider: {
+				getKeyboardNavigationLabel: () => 'a'
+			}
+		});
+
+		try {
+			await runWithFakedTimers({ useFakeTimers: true }, async () => {
+				tree.layout(200);
+				tree.setChildren(null, [{ element: 0 }]);
+				tree.setFocus([0]);
+				tree.domFocus();
+
+				tree.updateOptions({ indent: 12 });
+
+				dispatchKeydown(tree.getHTMLElement(), 'a', 'KeyA', 65);
+				await Promise.resolve();
+			});
+		} finally {
+			tree.dispose();
+		}
+	});
 });
 
 suite('CompressibleObjectTree', function () {

src/vs/editor/contrib/hover/browser/markerHoverParticipant.ts

@@ -22,6 +22,8 @@ import { CodeActionKind, CodeActionSet, CodeActionTrigger, CodeActionTriggerSour
 import { MarkerController, NextMarkerAction } from '../../gotoError/browser/gotoError.js';
 import { HoverAnchor, HoverAnchorType, IEditorHoverParticipant, IEditorHoverRenderContext, IHoverPart, IRenderedHoverPart, IRenderedHoverParts, RenderedHoverParts } from './hoverTypes.js';
 import * as nls from '../../../../nls.js';
+import { IMenuService, MenuId, MenuItemAction } from '../../../../platform/actions/common/actions.js';
+import { IContextKeyService } from '../../../../platform/contextkey/common/contextkey.js';
 import { ITextEditorOptions } from '../../../../platform/editor/common/editor.js';
 import { IMarker, IMarkerData, MarkerSeverity } from '../../../../platform/markers/common/markers.js';
 import { IOpenerService } from '../../../../platform/opener/common/opener.js';
@@ -65,6 +67,8 @@ export class MarkerHoverParticipant implements IEditorHoverParticipant<MarkerHov
 		@IMarkerDecorationsService private readonly _markerDecorationsService: IMarkerDecorationsService,
 		@IOpenerService private readonly _openerService: IOpenerService,
 		@ILanguageFeaturesService private readonly _languageFeaturesService: ILanguageFeaturesService,
+		@IMenuService private readonly _menuService: IMenuService,
+		@IContextKeyService private readonly _contextKeyService: IContextKeyService,
 	) { }
 
 	public computeSync(anchor: HoverAnchor, lineDecorations: IModelDecoration[]): MarkerHover[] {
@@ -206,12 +210,38 @@ export class MarkerHoverParticipant implements IEditorHoverParticipant<MarkerHov
 			}
 		}
 
+		// Menu-contributed actions (e.g. fix with inline chat)
+		const menuActions: MenuItemAction[] = [];
+		for (const [, actions] of this._menuService.getMenuActions(MenuId.MarkerHoverStatusBar, this._contextKeyService)) {
+			for (const action of actions) {
+				if (action instanceof MenuItemAction && action.enabled) {
+					menuActions.push(action);
+				}
+			}
+		}
+		const renderMenuActions = () => {
+			for (const action of menuActions) {
+				context.statusBar.addAction({
+					label: action.label,
+					commandId: action.id,
+					iconClass: action.class,
+					run: () => {
+						context.hide();
+						this._editor.setSelection(Range.lift(markerHover.range));
+						action.run();
+					}
+				});
+			}
+		};
+
 		if (!this._editor.getOption(EditorOption.readOnly)) {
 			const quickfixPlaceholderElement = context.statusBar.append($('div'));
 			if (this.recentMarkerCodeActionsInfo) {
 				if (IMarkerData.makeKey(this.recentMarkerCodeActionsInfo.marker) === IMarkerData.makeKey(markerHover.marker)) {
 					if (!this.recentMarkerCodeActionsInfo.hasCodeActions) {
-						quickfixPlaceholderElement.textContent = nls.localize('noQuickFixes', "No quick fixes available");
+						if (menuActions.length === 0) {
+							quickfixPlaceholderElement.textContent = nls.localize('noQuickFixes', "No quick fixes available");
+						}
 					}
 				} else {
 					this.recentMarkerCodeActionsInfo = undefined;
@@ -230,7 +260,12 @@ export class MarkerHoverParticipant implements IEditorHoverParticipant<MarkerHov
 
 				if (!this.recentMarkerCodeActionsInfo.hasCodeActions) {
 					actions.dispose();
-					quickfixPlaceholderElement.textContent = nls.localize('noQuickFixes', "No quick fixes available");
+					if (menuActions.length === 0) {
+						quickfixPlaceholderElement.textContent = nls.localize('noQuickFixes', "No quick fixes available");
+					} else {
+						quickfixPlaceholderElement.style.display = 'none';
+					}
+					renderMenuActions();
 					return;
 				}
 				quickfixPlaceholderElement.style.display = 'none';
@@ -274,13 +309,18 @@ export class MarkerHoverParticipant implements IEditorHoverParticipant<MarkerHov
 					});
 				}
 
+				renderMenuActions();
+
 				// Notify that the contents have changed given we added
 				// actions to the hover
 				// https://github.com/microsoft/vscode/issues/250424
 				context.onContentsChanged();
 
 			}, onUnexpectedError);
+		} else {
+			renderMenuActions();
 		}
+
 		return disposables;
 	}
 

src/vs/platform/actions/common/actions.ts

@@ -309,6 +309,7 @@ export class MenuId {
 	static readonly ChatViewSessionTitleNavigationToolbar = new MenuId('ChatViewSessionTitleNavigationToolbar');
 	static readonly ChatViewSessionTitleToolbar = new MenuId('ChatViewSessionTitleToolbar');
 	static readonly ChatContextUsageActions = new MenuId('ChatContextUsageActions');
+	static readonly MarkerHoverStatusBar = new MenuId('MarkerHoverParticipant.StatusBar');
 
 	/**
 	 * Create or reuse a `MenuId` with the given identifier