Skip to content

[pull] main from microsoft:main#1046

Merged
pull[bot] merged 43 commits intocode:mainfrom
microsoft:main
Mar 18, 2026
Merged

[pull] main from microsoft:main#1046
pull[bot] merged 43 commits intocode:mainfrom
microsoft:main

Conversation

@pull
Copy link

@pull pull bot commented Mar 18, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

bryanchen-d and others added 30 commits March 17, 2026 15:54
…#301186)

Move the show-checkmarks class toggle from individual content parts to
the row container level in chatListRenderer. This replaces N per-part
onDidChangeConfiguration subscriptions (one per tool invocation, terminal
tool, and code block pill) with a single subscription per rendered chat
element, significantly reducing listener accumulation on the configuration
service emitter in sessions with many tool invocations.
fix - update conditions for `UnpinAgentSessionAction`
* editors - update comment on modal close

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Update feedback command input format in SubmitFeedbackAction
* Add configuration updates for preferred light and dark themes on theme selection

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* debt - stop the log spam

* lets do actual programming
Prevent feedback display at the start or end of diff hunks in the editor
* feat: add inline editing for agent feedback comments

* feat: enable editing for code review comments and add updateComment method

* feat: disable action bar actions while editing feedback comment

When inline editing is active on a feedback item, all action bar
buttons (edit, convert, remove) are disabled to prevent conflicting
operations. Actions are re-enabled when editing ends (Enter/Escape/blur).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* feat: enhance chat permission picker with warning and info labels

* feat: enhance action label styles with opacity and hover effects
* Implement auto-detect color scheme feature for new users and update related services

* Add OS color-scheme auto-detection support for new users

Co-authored-by: Copilot <copilot@github.com>

* Add assertions to verify color scheme detection for high contrast themes

Co-authored-by: Copilot <copilot@github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…302772)

* feat - add rule to prevent static imports in critical startup path

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
fix: update list hover background color in 2026 Dark theme

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
)

* feat: add shadow configuration setting and update layout behavior

* fix: streamline shadow handling in layout and styles

* fix: update shadow variable for no-shadows class to use transparent zero-offset shadows

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* fix: update shadow handling to use Array.from for containers iteration

---------

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Add per-model configuration support to LanguageModelsService

* Update chatProvider version to 5 and add configuration schema support for per-model options

* Add per-model configuration support to chat request options

* Revert version number in chatProvider declaration from 5 to 4

* Refactor chat request options to use ILanguageModelChatRequestOptions interface and revert chatProvider version to 4

* Add per-model configuration support in LanguageModelsService and update ActionsColumnRenderer

* Enhance per-model configuration support by merging schema defaults with user config in sendChatRequest

* Add per-model configuration actions and update LanguageModelsService methods

* Optimize model resolution for default vendors by applying per-model configurations directly to resolved models

* Add per-model configuration actions for single model selection in ChatModelsWidget

* Improve label generation for model configuration actions by using propSchema.title and enhancing formatting

* Enhance model configuration action labels to indicate default values in LanguageModelsService

* Add languageModelsService to model action creation for enhanced toolbar actions

* Integrate languageModelsService into model action creation for improved model picker functionality

* Add configuration toolbar actions for models in chat model picker

* Refactor model configuration action handling to utilize languageModelsService for toolbar actions

* Add toolbar actions to model item creation in chat model picker

* Refactor action item rendering to flatten SubmenuActions into a single gear button for context menu access

* Enhance toolbar action interaction by preventing selection on click and updating visibility styles

* Refactor ActionItemRenderer to use a gear button for context menu access and improve toolbar action handling

* Refactor ActionItemRenderer to use inline menu for SubmenuActions and improve context menu handling

* Refactor ActionItemRenderer to use defaultMenuStyles for menu configuration

* Refactor ActionItemRenderer to display a gear button for SubmenuActions that opens an inline menu

* Add submenu support to ActionListItem and update styles for submenu indicator

* Enhance submenu handling in ActionItemRenderer with improved mouse event management and layout adjustments

* Refactor ActionItemRenderer to streamline submenu handling and improve hover interactions

* Prevent hover display for items with submenu actions to avoid conflicts

* Add hardcoded submenu actions for debugging in createModelItem function

* Refactor submenu positioning in ActionList to improve layout and visibility

* Fix submenu positioning to prevent overflow clipping and ensure visibility

* Refactor submenu positioning to append within action list's DOM context and adjust for transform offsets

* Refactor submenu positioning to append within row element and adjust layout for transform offsets

* Enhance submenu structure by adding rowElement to support fixed-position rendering and adjust overflow handling

* Refactor submenu handling to remove rowElement from submenu state and adjust positioning logic for improved layout

* Refactor submenu positioning to use bounding rectangles for accurate placement relative to the row element

* Refactor submenu positioning to append within action list's DOM context for improved layout

* Refactor submenu positioning to append within action-widget container and use fixed coordinates for accurate placement

* Refactor submenu positioning to append directly to the action list's DOM node and adjust placement logic for improved layout

* Refactor ActionList to set position of domNode to relative for accurate submenu positioning

* Remove hardcoded submenu actions from createModelItem and use action's toolbarActions instead

* Prevent hiding submenu when hovering over it to improve user interaction

* Add submenu indicator visibility handling and CSS class for submenu items

* Prevent hiding action widget when focus moves to a submenu

* Always render submenu indicator icon for consistent width and alignment

* Improve focus handling in ActionWidgetService to prevent premature hiding

* Refactor focus handling in ActionWidgetService to improve submenu interaction

* Prevent submenu from being focusable to maintain action widget focus

* Adjust submenu positioning logic to display correctly based on available space

* Add hasActiveSubmenu method to ActionList and update focus handling in ActionWidgetService

* Update hasActiveSubmenu method to account for scheduled submenu visibility

* Adjust submenu positioning to prevent overflow above the action list

* Remove scheduled submenu visibility check from hasActiveSubmenu method

* Enhance submenu positioning logic to dynamically determine expand direction based on available space

* Implement cleanupSubmenu method and update focus handling to ensure proper submenu cleanup on focus loss

* Refactor submenu handling: remove Menu widget and implement direct DOM rendering for submenu items

* Add check icon to submenu items and adjust styling for improved layout

* Immediately clean up submenu on hover change to enhance user experience

* Update submenu styles: increase min-width and adjust padding for better layout

* Refactor hover handling in ActionList: avoid showing hover for submenu items and adjust submenu display logic on hover

* Enhance submenu item rendering: add group label display and adjust styles for improved layout

* Refactor hover handling in ActionList: improve logic to skip re-rendering for active submenus

* Update submenu min-width: increase from 160px to 220px for improved layout

* Update submenu styles: change min-width to max-content for better adaptability

* Update action widget styles: set min-width to 200px for improved layout

* Improve submenu hover handling: prevent hiding when hovering over the same row or submenu

* Update submenu item hover styles: change background and text colors for better visibility

* Fix submenu selector handling: update class name for submenu detection and prevent default mouse down event

* Hide submenu after action execution to improve user experience

* Update submenu item hover styles: change background and text colors for improved visibility

* Refactor LanguageModelsService: update group retrieval logic to use configuration service as the source of truth

* Refactor LanguageModelsService: enhance model configuration handling by removing default properties and managing group updates

* Add model configuration description retrieval to LanguageModelsService

* Refactor LanguageModelsService: update property schema handling to use showInPicker and enhance description formatting

* Add showInPicker property to IJSONSchema and update LanguageModelsService to utilize it

* Refactor LanguageModelsService: update showInPicker handling to improve type safety and simplify value retrieval

* Add showInPicker property to ILanguageModelConfigurationSchemaProperty and update configurationSchema type in ILanguageModelChatMetadata

* Enhance model hover content: include configuration properties marked with showInPicker

* Refactor buildModelPickerItems: pass languageModelsService to createModelItem for improved functionality

* Refactor submenu handling in ActionList: add delay for hiding submenu to improve user experience

* Refactor language model options: rename configuration to modelConfiguration for consistency

* Refactor language model options: rename modelConfiguration to configuration for consistency

* Enhance ChatLanguageModelsDataContribution: add per-model configuration schemas for improved schema validation

* Enhance language model settings management: implement model settings update mechanism and extend interfaces for configuration handling

* Enhance language model integration: add model configuration handling in chat agent requests and update type definitions

* Refactor language model settings handling: remove unused model settings methods and update model configuration retrieval in chat requests

* Refactor language model configuration handling: rename configuration to modelConfiguration for consistency

* Enhance RunSubagentTool: add model configuration retrieval for user-selected model

* Refactor language model configuration: rename 'models' to 'settings' for consistency

* Enhance ActionList: prevent hover display when a submenu is active and adjust submenu positioning to avoid scrollbar overlap

* Enhance ActionList: add description text element and style submenu indicator for better interaction

* Enhance ActionItemRenderer and CSS: adjust submenu indicator positioning and improve hover feedback for submenu items

* Enhance ActionItemRenderer and CSS: wrap description and submenu indicator for improved hover feedback

* Enhance ActionWidget CSS: adjust description group visibility and padding for submenu items

* Refactor ActionItemRenderer: rearrange description group and toolbar for improved layout and hover feedback

* Enhance ActionWidget CSS: adjust padding for submenu indicator for improved layout

* Enhance ActionList hover behavior: update submenu display logic to trigger on description group hover

* Enhance ActionWidget CSS: update submenu indicator visibility on row hover for improved user interaction

* Refactor ActionList: remove submenu check from hover display logic for improved user experience

* Refactor ActionList hover logic: improve submenu visibility handling during mouse movement

* Enhance LanguageModel configuration: add support for enum item labels and descriptions in model picker

* Enhance ActionList submenu rendering: add group headers and descriptions for improved clarity

* Enhance ModelPicker: update label rendering to include model configuration descriptions and re-render on model changes

* Enhance ActionList hover functionality: show hover content in submenu when no submenu actions are present and add CSS styles for hover section

* Enhance ActionList submenu hover styles: adjust padding, font size, and colors for improved readability

* Refactor ActionList submenu rendering: improve separator logic and remove unused header styles

* Enhance ActionList submenu rendering: add group headers with labels and separators for improved organization

* Enhance ActionList submenu hover styles: adjust padding for improved layout

* Refactor ActionList rendering: remove unused description group and submenu indicator styles for cleaner layout

* Enhance ActionList submenu hover styles: adjust padding, font size, and line height for improved readability

* Enhance action list submenu hover styles: adjust padding, font size, and line height for improved readability and layout

* Enhance action list submenu styles: adjust padding for improved layout

* Enhance action list submenu group label styles: increase font size for better visibility

* Update action list submenu group label color for improved visibility

* Enhance ActionList submenu positioning and overflow handling for improved layout and visibility

* Enhance action list item layout: add right padding for improved spacing

* Refactor ActionList submenu: simplify styles and remove unused properties

* Enhance ActionList hover behavior: switch to instant hover display for improved responsiveness

* Enhance ActionList hover behavior: implement hover delay for improved user experience

* Refactor ActionList hover behavior: switch to delayed hover display for improved user experience

* Enhance ModelPickerActionItem: re-render label on model configuration changes

* Enhance ModelPickerWidget: re-register label rendering on language model changes

* Refactor ILanguageModelConfigurationSchemaProperty: rename showInPicker to isVisible for clarity

* Refactor ILanguageModelConfigurationSchemaProperty: rename isVisible to isPrimary for clarity

* Refactor ILanguageModelConfigurationSchemaProperty: rename isPrimary to showInDescription for clarity

* Refactor ILanguageModelConfigurationSchemaProperty: rename showInDescription to showInModelPicker for clarity

* Refactor ILanguageModelConfigurationSchemaProperty: rename showInModelPicker to pinToModelPicker for clarity

* Refactor ILanguageModelConfigurationSchemaProperty: change pinToModelPicker to group for improved clarity

* Refactor LanguageModelConfigurationSchemaProperty and LanguageModelConfigurationSchema: update configurationSchema type and add detailed property definitions

* Refactor LanguageModelConfigurationSchema: simplify schema property definition and enhance documentation

* Refactor LanguageModelConfigurationSchema: enhance documentation for properties and clarify enumItemLabels and group usage

* Refactor ILanguageModelConfigurationSchema: inline schema property definition and enhance documentation for group and enumItemLabels

* Refactor ILanguageModelsService: enhance documentation for getModelConfigurationDescription to clarify its purpose and usage

* Refactor language model configuration handling: replace direct service method calls with utility function for improved clarity and maintainability

* Refactor ActionItemRenderer: remove unused descriptionText property and streamline description handling

* Refactor ActionItemRenderer: streamline description element creation by removing redundant code

* Refactor ActionList: enhance hover content rendering and streamline submenu actions handling

* Refactor ActionListHoverContent: extract group rendering logic into ActionListHoverGroup class

* Refactor ActionListHoverContent and ActionListHoverGroup: enhance event handling and streamline disposables management

* Refactor ActionListHoverGroup and ActionListHoverContent: integrate Menu widget for submenu actions and remove unused CSS styles

* Refactor ActionListHoverGroup and ActionListHoverContent: remove unused Menu widget and enhance submenu item styling

* Enhance ActionList keyboard navigation and accessibility: add support for submenu actions with arrow keys and improve focus handling for submenu items

* Add OpenModelConfigPickerAction and model configuration picker UI component

* Refactor ModelConfigPickerActionItem render method: streamline DOM node creation and class assignment

* Enhance ModelConfigPickerActionItem: add disabled state handling for navigation actions

* Enhance ModelConfigPickerActionItem: add header for submenu actions with group label

* Enhance ModelConfigPickerActionItem: update submenu header to use action label as group title

* Refactor ModelConfigPickerActionItem and ModelPickerActionItem: simplify navigation properties handling and remove unused language models service references

* Enhance ModelConfigPickerActionItem: add navigation-group configuration values display in model picker

* Enhance ModelConfigPickerActionItem and language model interfaces: add support for enum icons in model configuration

* Refactor ModelConfigPickerActionItem and language model interfaces: replace enumIcons with a single icon property for configuration

* Refactor ModelConfigPickerActionItem and language model interfaces: remove icon property from configuration schema

* Refactor ActionList and ActionWidgetService: remove unused submenu actions and related hover logic

* Clarify comment in OpenModelConfigPickerAction: specify that the picker is opened by the ModelConfigPickerActionItem view item on click

* Remove model config picker UI: delete ModelConfigPickerActionItem, remove OpenModelConfigPickerAction and chatModelHasNavigationConfig context key

The config picker dropdown button in the chat input has been removed while keeping the underlying per-model configuration API, settings support, and model management editor intact.

Also fix ILanguageModelConfigurationSchema to not include boolean in properties type (incompatible with IJSONSchema), and add showUnavailableFeatured/showFeatured to IModelPickerDelegate.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Refactor LanguageModelConfigurationSchema: adjust properties type definition for clarity

* Refactor LanguageModelsService: merge configuration options and simplify default checks

* Revert newChatViewPane changes and fix code review issues

- Make showUnavailableFeatured/showFeatured optional on IModelPickerDelegate
  (defaults to true), removing the need to change newChatViewPane.ts
- Fix sendChatRequest merge order: caller's configuration takes precedence
  over stored model config
- Remove dead typeof propSchema !== 'boolean' checks after type cleanup

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Revert unrelated changes to chatModelPicker and modelPickerActionItem

These files were modified to add showUnavailableFeatured/showFeatured
which already landed on main separately. Revert to merge-base versions
to keep the diff clean.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Revert unrelated changes to chatInputPart.ts

Revert to merge-base version — the diff was from main changes
(delegation picker, showUnavailableFeatured/showFeatured) that
will come in on merge.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ensure terminal instance exists before operations
…d isolation pickers (#302797)

* refactor: rename SessionProject to SessionWorkspace and update related references

* fix: update filter placeholder text in project picker to "Search Workspaces..."

* feat: add SessionWorkspace class to represent workspaces for sessions

* feat: implement ProjectPicker class for unified project selection

* fix: update SessionTargetType to use 'copilot-cli' instead of 'cli'

* refactor: rename targetMode to isolationMode in NewSession and related classes

* refactor: rename LocalNewSession to CopilotCLISession and update related references

* feat: set project in session type picker for local sessions

* fix: ensure project is set in session type picker for both remote and local sessions

* fix: reset isolation mode to worktree when isolation option is disabled

* delete file
…#302818)

Replace loading icon with clock icon for running checks in CI status widget
* Initial plan

* Raise notification z-index above modal editor backdrop (#302271)

Notifications (toasts and center) had z-index: 1000 which is below the
modal editor backdrop at z-index: 2540, making them hard to read when a
modal was open. Raised to 2545 so they appear above the modal backdrop
but below quick input (2550) and dialogs (2575).

Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
…ak-show-checkmarks

fix: reduce listener leak from per-part show-checkmarks subscriptions
dileepyavan and others added 13 commits March 18, 2026 15:41
…dbox config (#302834)

* changes to include workspace folders

* adding tests
Enhance ListenerLeakError and ListenerRefusalError to include detailed debugging information
* feat: implement conditional blocks processing in release notes

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Fix compilation issue

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…302610)

Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 5.4.1 to 5.5.6.
- [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases)
- [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md)
- [Commits](NaturalIntelligence/fast-xml-parser@v5.4.1...v5.5.6)

---
updated-dependencies:
- dependency-name: fast-xml-parser
  dependency-version: 5.5.6
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
* aiCustomization: make plugin/extension/builtin files read-only

- Open plugin, extension, and built-in customization files as read-only
  in the editor, with a message explaining they cannot be edited.
- Extract isReadonlyStorage() helper to DRY the repeated storage type
  check used in both the open and delete actions.

Fixes #301292

(Commit message generated by Copilot)

* pr comments
feat - enhance panel visibility handling and focus management in workbench
Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 5.4.2 to 5.5.6.
- [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases)
- [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md)
- [Commits](NaturalIntelligence/fast-xml-parser@v5.4.2...v5.5.6)

---
updated-dependencies:
- dependency-name: fast-xml-parser
  dependency-version: 5.5.6
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pull pull bot locked and limited conversation to collaborators Mar 18, 2026
@pull pull bot added the ⤵️ pull label Mar 18, 2026
@pull pull bot merged commit 7e1b034 into code:main Mar 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.