[pull] develop from mermaid-js:develop #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
…larity on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
…ntation on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
…b.com/mermaid-js/mermaid into shared-rendering-changes-for-markdown
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
I had to slightly modify how `createLabel()` is called in `rectWithTitle.ts` since TypeScript is not smart enough to know that only arrays have `textRows.join`. I didn't set a default value for `style`, since currently it fails if `htmlLabels: false` is set.
Allow passing `width: Number.POSITIVE_INFINITY` to disable wrapping when calling `createText`. This also disables centreing for HTML labels, for backwards compatibility with Mermaid v10 behaviour.
Change `createLabel` to just call `createText`, except with `markdown: false` set. This aligns how nodes and edges look when rendering using markdown and not using markdown. This adds support for KaTeX and embedding FontAwesome icons from iconpacks in some of these older labels. One unfortunate side-effect is that we need to reset the `.width` and `.height` of the first child of the created element, if-and-only-if it's a HTML label and not an SVG label, but luckily, everywhere except `edges.js` already does that for us.
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
…m whitespace in nonMarkdownToLines; simplify title assignment in rectWithTitle on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
…-markdown Standardize label rendering via createText (KaTeX + iconpack support)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )