[pull] master from mattermost:master#588
Merged
pull[bot] merged 6 commits intocode:masterfrom Mar 25, 2026
Merged
Conversation
#35728) * Fix plugin API CreateChannel read-after-write failure with read replicas LocalCacheChannelStore did not override Save, so newly created channels were never added to channelByIdCache. When a plugin called CreateChannel followed immediately by AddChannelMember, the GetChannel lookup missed the cache and fell through to GetReplica(), which on deployments with DataSourceReplicas could read from a replica that hadn't replicated the channel yet, returning "channel not found". Add a Save override to LocalCacheChannelStore that populates channelByIdCache after a successful save, following the same pattern used by LocalCacheTermsOfServiceStore.Save.
* Add shared channel integration test tool (MM-67944) Add tools/sharedchannel-test, a standalone Go tool that validates shared channel synchronization between two real Mattermost Enterprise instances. The tool builds and manages two server processes with separate databases, establishes a remote cluster connection, and runs integration tests for membership, post, and reaction sync. Test coverage: - Membership: add, remove, re-add, bulk remove - Posts: create, edit, delete - Reactions: add, remove Uses mlog with dual console targets (stdout for info, stderr for errors) and exits non-zero on failure for CI integration.
Co-authored-by: Mattermost Build <build@mattermost.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )