[pull] master from mattermost:master #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MM-67269 - Fix popout windows for subpath deployments Popout windows were failing with 404 errors when Mattermost is served from a subpath (e.g., https://company.com/mattermost). The popout functions were constructing URLs without including the subpath prefix. Changes: - Updated popoutThread() and popoutRhsPlugin() to use getBasePath() helper function which includes window.basename - Added unit tests to verify popout URLs include subpath when configured - Follows established pattern used throughout codebase (getSiteURL, cookie paths, React Router) This ensures popout windows open at the correct URL: /subpath/_popout/... instead of /_popout/... Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * Clear mocks and set default base path in tests --------- Co-authored-by: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> Co-authored-by: Mattermost Build <build@mattermost.com>
* adds detailed error message to ES test connection * changed to semicolon for consistency * updated snapshots for elasticsearch settings test
Automatic Merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )