[pull] master from mattermost:master #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add tooltip support and error handling for action buttons - Add tooltip field to PostAction type definition - Display tooltips on hover for action buttons - Add comprehensive error handling for button actions - Show error messages when actions fail - Clear previous errors on subsequent actions - Add tests for error handling functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Add E2E tests for action button error handling and tooltips - Test error message display when action buttons fail - Test error clearing when successful actions are performed - Test tooltip display on action button hover - Use scoped selectors to avoid test interference - Cover complete error lifecycle and tooltip functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Use WithTooltip component for action button tooltips Replace native HTML title attribute with WithTooltip component to provide consistent tooltip styling and behavior across the application. Changes: - Import and wrap ActionBtn with WithTooltip component - Remove title attribute from ActionBtn - Update E2E test to check for .tooltipContainer instead of title attribute 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Fix TypeScript errors and test patterns in message attachment tests - Fix TypeScript type errors in mock event objects by using arrow functions instead of jest.fn() - Update async test pattern to use process.nextTick() with done callback instead of await - Update test snapshots to reflect error handling wrapper div - Fix whitespace formatting in E2E test file 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * updated actionError to accept react node, replace hardcoded error with FormattedMessage components * Fix test to handle FormattedMessage in actionError state Update test expectation to check for FormattedMessage React element instead of plain string when no error message is provided. This aligns with the recent change to support internationalization in error messages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * Disable tooltip interactions when no tooltip text is present Adds disabled prop to WithTooltip component when action.tooltip is empty or undefined, preventing unnecessary tooltip event handlers from being attached to action buttons that don't have tooltips. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * Add tests for action button tooltip behavior Adds three test cases to verify tooltip functionality: - Tooltip is disabled when action.tooltip is undefined - Tooltip is disabled when action.tooltip is empty string - Tooltip is enabled and displays correctly when action.tooltip has a value 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * fix e2e test --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Mattermost Build <build@mattermost.com>
* test: migrate enzyme to rtl * replace renderWithIntl with renderWithContext * remove jest.clearAllMocks * use userEvent * fix unrelated lint error
Co-authored-by: Mattermost Build <build@mattermost.com>
* Handled WS payload * increased WS faliure timeout to elliminate flakiness * lint fix --------- Co-authored-by: Mattermost Build <build@mattermost.com>
Automatic Merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )