[pull] main from TryGhost:main #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref https://linear.app/ghost/issue/BER-3184 Member `commenting` and `can_comment` fields were being parsed and serialized inconsistently across different API surfaces (REST API, webhooks, comments API). This moves the serialization into Bookshelf's parse/format/toJSON lifecycle hooks so every Member load automatically has correctly formatted data, eliminating redundant parsing and ensuring consistency across all API responses including webhooks.
closes https://linear.app/ghost/issue/BER-3245/ - with the new React Admin shell the scrollable element for the main content area has changed from `.gh-main` to `.shade-admin main` meaning our infinite scroll and other scroll-detect handlers inside Ember Admin were not firing correctly - the React shell is now GA so these changes aren't behind the `adminForward` labs flag
This PR contains the following updates: | Package | Update | Change | |---|---|---| | ghost/traffic-analytics | patch | `1.0.42` → `1.0.43` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - Only on Sunday and Saturday ( * * * * 0,6 ), Between 12:00 AM and 12:59 PM, only on Monday ( * 0-12 * * 1 ) in timezone Etc/UTC. 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/TryGhost/Ghost). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Mi4xIiwidXBkYXRlZEluVmVyIjoiNDIuOTIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ref <#26022 (comment)> I forgot to set `Content-Type: application/json` in the magic link endpoint's honeypot response. This could let bots know whether they're being detected. [@coderabbitai pointed this out][0] and I missed it. Taught me not to ignore the automatic review! [0]: #26022 (comment)
*This change should have no user impact.* This import was unnecessary and can be removed.
_This test-only change should have no user impact._ This makes two changes to the `AdapterManager` tests: 1. Instead of using `try`, use `assert.throws()` or just call the function. 2. Switch from Should.js to `node:assert/strict` and Sinon assertions.
_This test-only change should have no user impact._ This makes three changes to the custom redirect validation unit tests: 1. Instead of using `try`, use `assert.throws()`. 2. Switch from Should.js to `node:assert/strict`. 3. Fix type errors in the file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )