[pull] main from TryGhost:main #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gun (#26063) ref [GVA-646](https://linear.app/ghost/issue/GVA-646/sync-spam-complaint-suppressions-from-mailgun-to-disable-members) At the moment, spam complaints persist in Mailgun. This means that for sites that share a domain, a member creating a spam complaint on one site can impact another. Also, if the spam complaint is made in error, the site admin has no way to fix the issue on behalf of the member.
The posts app's useFeatureFlag hook was parsing feature flags from the settings JSON, while the rest of the codebase reads them directly from config.labs. This inconsistency meant changes made via the FeatureToggle component (which updates the config cache) wouldn't be reflected until the settings cache was also invalidated. This change simplifies the hook to read from config.labs directly, aligning it with how other apps check feature flags and ensuring immediate reactivity when flags are toggled.
No ref Small class tweaks for the view that members see if they've had commenting disabled.
no issue - our seed data for dev/testing should include replies-to-replies so we can work with the full spectrum of comment states - reduced randomness for # of comments per post and increased bias towards replies for a better spread - fixed replies sometimes having an earlier timestamp than the parent comment --- With these changes, for the default of 10 comments per post (used unless total number of comments specified) you should now expect approximately: ~8-12 comments per post (instead of 0-10) ~4-5 top-level comments (first comment + ~45% of remainder) ~3-4 direct replies ~2-3 replies-to-replies
ref https://linear.app/ghost/issue/FEA-535 Members on a tier with a trial period were being shown retention offers, which led to a confusing "Free trial - Ends {date}" message after redemption. This change skips retention offers for subscriptions with an active trial period (`trial_end_at` in the future), matching the existing behavior for offer-based trials
Changelog for v1.3.0 -> 1.3.1: - Fixed reply form showing parent comment author's details - Added disabled state for Members whose commenting ability is disabled - Updated i18n translations
no refs. - Sort tiers by signup count (highest first) for better visual hierarchy - Expand color palette from 5 to 10 colors to support more tiers
no ref. - The font size for breakdown values were one step larger than the rest.
ref https://linear.app/ghost/issue/FEA-547 - Changed displayed label for once offers from "$5/month - Next payment" to "$5 - Next payment", following how Stripe renders the discounted price for once offers - Also added the corresponding i18n key
Changelog for v2.58.0 -> 2.58.1: - Updated i18n translations - 4529ad74b8
no ref *This cleanup change should have no user impact.* This removes references to a top-level `labs` variable and its usages. Two reasons for doing this: 1. Portal uses `site.labs` to handle feature flags. See 3d4eeff. 2. The top-level `labs` property was useless because it was always initialized to `{}`.
ref bb9a69e *This change should have no user impact.* i18n has been enabled since November 2024. We can remove it from our list of always-on feature flags, remove `labs.isSet('i18n')` calls, and a bit of associated code.
closes https://linear.app/ghost/issue/BER-3199/ - adds link to Comments-UI comment admin menu that deep links to the comment inside the new admin-area comment moderation screen
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )