[pull] main from TryGhost:main #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary change to make sure there's a full QA run of the feature before shipping.
ref https://linear.app/ghost/issue/BER-3184 When a member has their commenting ability disabled, they now see a "Commenting disabled" message instead of the comment form, and cannot like, reply, edit, or delete comments.
no ref You generally only need a few characters to filter to the field you want, and often autocorrect changes this to something you *do not* want.
ref https://linear.app/ghost/issue/FEA-537 - The API now returns the next payment amount for a subscription, taking into account active offers for both signup and retention type of offers - Thus, we can now remove the next amount calculation logic from Portal
Changelog for v2.57.1 -> 2.58.0: - acd21233b9
This PR contains the following updates: | Package | Update | Change | |---|---|---| | ghost/traffic-analytics | patch | `1.0.41` → `1.0.42` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - Only on Sunday and Saturday ( * * * * 0,6 ), Between 12:00 AM and 12:59 PM, only on Monday ( * 0-12 * * 1 ) in timezone Etc/UTC. 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/TryGhost/Ghost). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Mi4xIiwidXBkYXRlZEluVmVyIjoiNDIuOTIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
*This change should have no user impact.* This method takes no arguments, but we passed them anyway. Let's remove that.
ref https://linear.app/ghost/issue/NY-943 When you sign up with a `@gmail.com` email, the "Now check your email!" has an updated button which takes you to `mail.google.com`. In the future, we plan to show this link in other parts of the portal.
closes https://linear.app/ghost/issue/NY-974 - increases shards for running the E2E tests from 4 to 8
closes https://linear.app/ghost/issue/NY-976 - If a test fails in our E2E tests, there's not really a reason to continue running all of them - we know we'll need to fix the failing test to get to green - With this change we set maxFailures to 1 in the Playwright config, but I think that will only apply per shard. For example, if a test fails in shard 2 it won't run the rest of them, but shards 1, 3, and 4 will continue. To solve that we set `fail-fast: true` on the e2e workflow, and now we'll get the benefit of this both locally and in CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )