Skip to content

[pull] main from firecrawl:main #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Jan 29, 2026
Merged

[pull] main from firecrawl:main #394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions apps/api/src/search/v2/fireEngine-v2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,19 @@ function normalizeSearchTypes(
* Checks if the response has at least one requested type with results.
* This allows partial results to be returned when some sources have data
* but others don't, instead of requiring all sources to have results.
*
* MOGERY: temp removed to fix bug
*/
function hasAnyResults(
response: SearchV2Response,
requestedTypes: SearchResultType[],
): boolean {
if (!response || Object.keys(response).length === 0) return false;
return requestedTypes.some(type => {
const results = response[type];
return Array.isArray(results) && results.length > 0;
});
}
// function hasAnyResults(
// response: SearchV2Response,
// requestedTypes: SearchResultType[],
// ): boolean {
// if (!response || Object.keys(response).length === 0) return false;
// return requestedTypes.some(type => {
// const results = response[type];
// return Array.isArray(results) && results.length > 0;
// });
// }

export async function fire_engine_search_v2(
q: string,
Expand Down Expand Up @@ -75,8 +77,7 @@ export async function fire_engine_search_v2(

const result = await executeWithRetry<SearchV2Response>(
() => attemptRequest<SearchV2Response>(url, data, abort),
(response): response is SearchV2Response =>
response !== null && hasAnyResults(response, requestedTypes),
(response): response is SearchV2Response => response !== null,
abort,
);

Expand Down
Loading