Skip to content

Conversation

@misyuari
Copy link

@misyuari misyuari commented Jan 26, 2026

Summary

  • Implement disabled_skills config support in createBuiltinSkills() to allow filtering skills at source
  • Propagate disabledSkills through skill resolution functions, agent creation, and config handler
  • Add comprehensive tests for disabled skill filtering behavior

Changes

  • src/features/builtin-skills/skills.ts: Add optional { disabledSkills?: Set } parameter to createBuiltinSkills() and filter returned skills array
  • src/features/opencode-skill-loader/skill-content.ts:
    • Add disabledSkills to SkillResolutionOptions interface
    • Update getAllSkills(), resolveSkillContent(), resolveMultipleSkills(), and async variants to pass and respect disabled skills
    • Bypass cache when disabled skills are provided to ensure correct filtering
  • src/agents/utils.ts: Add disabledSkills parameter to createBuiltinAgents() and pass to createBuiltinSkills()
  • src/plugin-handlers/config-handler.ts: Create disabledSkills set from pluginConfig.disabled_skills and pass to createBuiltinAgents()
  • src/index.ts: Pass disabledSkills to createBuiltinSkills() call, removing redundant manual filtering
  • Tests: Add 18+ new test cases across skills.test.ts, skill-content.test.ts, and utils.test.ts covering disabled skill scenarios

Testing

npx bun test

Run specific test suites

npx bun test src/features/builtin-skills/skills.test.ts
npx bun test src/features/opencode-skill-loader/skill-content.test.ts
npx bun test src/agents/utils.test.ts

Type check

npx bun run typecheck


Summary by cubic

Adds support for disabling specific skills via pluginConfig.disabled_skills, ensuring disabled skills are filtered at the source and treated as not found in resolution and agent prompts. Removes redundant manual filtering and keeps agent prompts accurate.

  • New Features

    • createBuiltinSkills now accepts disabledSkills and filters built-in skills.
    • Skill resolution (sync/async) respects disabledSkills.
    • createBuiltinAgents passes disabledSkills to built-in skills; agent prompts exclude disabled skills.
    • Config handler reads pluginConfig.disabled_skills and wires it through to agents/skills.
    • Added tests covering disabled skill behavior across loaders, agents, and built-ins.
  • Dependencies

    • Bumped oh-my-opencode optional binaries to 3.0.1 across all platforms.

Written for commit ef5e8c1. Summary will update on new commits.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026

All contributors have signed the CLA. Thank you! ✅
Posted by the CLA Assistant Lite bot.

@misyuari misyuari force-pushed the fix/refactor-skills branch 2 times, most recently from c2c1746 to e4fe016 Compare January 26, 2026 06:27
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@misyuari misyuari force-pushed the fix/refactor-skills branch from e4fe016 to ef5e8c1 Compare January 26, 2026 07:21
@misyuari
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant