fix: return friendly error when file not found in look_at #1106
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add existsSync check before processing file - Return clear error message instead of throwing JSON parse error - Improves UX when users accidentally pass non-existent file paths
Contributor
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA). To sign the CLA, please comment on this PR with: This is a one-time requirement. Once signed, all your future contributions will be automatically accepted. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Collaborator
|
@oasjkow please sign the cla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using the
look_attool with a non-existent file path, it previously threw a crypticSyntaxError: JSON Parse error: Unexpected EOFerror. This PR adds a file existence check that returns a clear, user-friendly error message instead.Changes
existsSynccheck before processing the fileError: File not found: <path>Testing
bun test src/tools/look-at- 7 tests)bun run build)Summary by cubic
look_at now checks for file existence and returns "Error: File not found: " for invalid paths, instead of a cryptic JSON parse error. Adds an existsSync guard and logs the error for easier debugging.
Written for commit 727b762. Summary will update on new commits.