fix(background-agent): track and cancel completion timers to prevent memory leaks #1058
+107
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes memory leak in
BackgroundManagerwhere completion timers (5-minute delayed cleanup) were not tracked or cancelled on shutdown, causing the manager instance to be held in memory by timer callbacks.Investigation Summary
Investigated the 6 memory leak patterns mentioned in #1043:
setTimeouttimers (manager.ts:1011-1018)setIntervalpolling (manager.ts:790-804)session-notification.tsMaps/SetsmaxTrackedSessionstool-input-cache.tscacheatlas/index.tspendingFilePathscontext-injector/collector.tssessionsChanges
completionTimers: Map<string, ReturnType<typeof setTimeout>>to track timer IDsnotifyParentSession()when scheduling 5-minute cleanupsession.deletedeventshutdown()methodTesting
Closes #1043
Summary by cubic
Fixed a memory leak in BackgroundManager by tracking and cancelling 5-minute completion timers. Timers are now canceled on shutdown and when tasks are deleted, preventing the manager from being kept in memory (fixes #1043).
Written for commit 9e260ed. Summary will update on new commits.