refactor: make release script OS-agnostic by migrating from bash to node #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code PushUp😐 Code PushUp report is unchanged – compared current commit cc0289e with previous commit 7daeb44. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories
|
matejchalk
approved these changes
Mar 4, 2025
|
|
||
| try { | ||
| // Get the latest release tag | ||
| let latestTag = (await git.tags()).latest |
Contributor
There was a problem hiding this comment.
This is a little different than the original bash command - git describe --tags --match='v*.*.*' "$(git rev-list --tags --max-count=1)". I guess non-version tags might cause issues. But it's probably an edge case, and the latest tag is only informative anyway, so not a blocker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release script migrated to node using
simple-gitand tested for latest release