Skip to content

fix(plugin-js-packages): handle empty output from yarn outdated #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matejchalk merged 1 commit into from
Mar 26, 2025
Merged

fix(plugin-js-packages): handle empty output from yarn outdated #982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/plugin-js-packages/src/lib/package-managers/yarn-classic/outdated-result.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@

export function yarnv1ToOutdatedResult(output: string): OutdatedResult {
const yarnv1Outdated = fromJsonLines<Yarnv1OutdatedResultJson>(output);
const fields = yarnv1Outdated[1].data.head;
const dependencies = yarnv1Outdated[1].data.body;
const fields = yarnv1Outdated[1]?.data.head ?? [];

Check failure on line 23 in packages/plugin-js-packages/src/lib/package-managers/yarn-classic/outdated-result.ts

View workflow job for this annotation

GitHub Actions / Code PushUp

<✓> Code coverage | Branch coverage 

1st branch is not taken in any test case.
const dependencies = yarnv1Outdated[1]?.data.body ?? [];

Check failure on line 24 in packages/plugin-js-packages/src/lib/package-managers/yarn-classic/outdated-result.ts

View workflow job for this annotation

GitHub Actions / Code PushUp

<✓> Code coverage | Branch coverage 

1st branch is not taken in any test case.

// no outdated dependencies
if (dependencies.length === 0) {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-js-packages/src/lib/package-managers/yarn-classic/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ type Yarnv1Table = {
};
};

export type Yarnv1OutdatedResultJson = [Yarnv1Info, Yarnv1Table];
export type Yarnv1OutdatedResultJson = [Yarnv1Info, Yarnv1Table] | [];