-
Notifications
You must be signed in to change notification settings - Fork 15
refactor(utils): make execute process log compact #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
packages/utils/src/lib/format-command-log.integration.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import path from 'node:path'; | ||
| import { describe, expect, it } from 'vitest'; | ||
| import { removeColorCodes } from '@code-pushup/test-utils'; | ||
| import { formatCommandLog } from './format-command-log.js'; | ||
|
|
||
| describe('formatCommandLog', () => { | ||
| it('should format simple command', () => { | ||
| const result = removeColorCodes( | ||
| formatCommandLog('npx', ['command', '--verbose']), | ||
| ); | ||
|
|
||
| expect(result).toBe('$ npx command --verbose'); | ||
| }); | ||
|
|
||
| it('should format simple command with explicit process.cwd()', () => { | ||
| const result = removeColorCodes( | ||
| formatCommandLog('npx', ['command', '--verbose'], process.cwd()), | ||
| ); | ||
|
|
||
| expect(result).toBe('$ npx command --verbose'); | ||
| }); | ||
|
|
||
| it('should format simple command with relative cwd', () => { | ||
| const result = removeColorCodes( | ||
| formatCommandLog('npx', ['command', '--verbose'], './wololo'), | ||
| ); | ||
|
|
||
| expect(result).toBe(`wololo $ npx command --verbose`); | ||
| }); | ||
|
|
||
| it('should format simple command with absolute non-current path converted to relative', () => { | ||
| const result = removeColorCodes( | ||
| formatCommandLog( | ||
| 'npx', | ||
| ['command', '--verbose'], | ||
| path.join(process.cwd(), 'tmp'), | ||
| ), | ||
| ); | ||
| expect(result).toBe('tmp $ npx command --verbose'); | ||
| }); | ||
|
|
||
| it('should format simple command with relative cwd in parent folder', () => { | ||
| const result = removeColorCodes( | ||
| formatCommandLog('npx', ['command', '--verbose'], '..'), | ||
| ); | ||
|
|
||
| expect(result).toBe(`.. $ npx command --verbose`); | ||
| }); | ||
|
|
||
| it('should format simple command using relative path to parent directory', () => { | ||
| const result = removeColorCodes( | ||
| formatCommandLog( | ||
| 'npx', | ||
| ['command', '--verbose'], | ||
| path.dirname(process.cwd()), | ||
| ), | ||
| ); | ||
|
|
||
| expect(result).toBe('.. $ npx command --verbose'); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import ansis from 'ansis'; | ||
| import path from 'node:path'; | ||
|
|
||
| /** | ||
| * Formats a command string with optional cwd prefix and ANSI colors. | ||
| * | ||
| * @param {string} command - The command to execute. | ||
| * @param {string[]} args - Array of command arguments. | ||
| * @param {string} [cwd] - Optional current working directory for the command. | ||
| * @returns {string} - ANSI-colored formatted command string. | ||
| */ | ||
| export function formatCommandLog( | ||
| command: string, | ||
| args: string[] = [], | ||
| cwd: string = process.cwd(), | ||
| ): string { | ||
| const relativeDir = path.relative(process.cwd(), cwd); | ||
|
|
||
| return [ | ||
| ...(relativeDir && relativeDir !== '.' | ||
| ? [ansis.italic(ansis.gray(relativeDir))] | ||
| : []), | ||
| ansis.yellow('$'), | ||
| ansis.gray(command), | ||
| ansis.gray(args.map(arg => arg).join(' ')), | ||
| ].join(' '); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.