Skip to content

Conversation

@matejchalk
Copy link
Collaborator

Ran into problem with JS packages when Node prints a deprecation warning to output. It doesn't have any effect on the audit and outdated commands, but it caused error nonetheless. Now such unrelated warnings should be ignored.

@github-actions github-actions bot added 🔬 testing writing tests 🧩 utils 🧩 js-packages-plugin Plugin for audit and outdated dependencies labels Mar 5, 2025
@matejchalk matejchalk added the 🐛 bug something isn't working label Mar 5, 2025
@matejchalk matejchalk requested a review from vmasek March 5, 2025 15:04
@matejchalk matejchalk marked this pull request as ready for review March 5, 2025 15:04
vmasek
vmasek previously approved these changes Mar 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 6123ba1 with previous commit 703c27e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 52 🟡 50 ↓ −1.8
Code coverage 🟢 91 🟢 91 ↑ +0.1
Security 🟡 75 🟡 75
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 4 audits regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 52 🟡 50 ↓ −1.8
Code coverage Code coverage metrics 🟢 91 🟢 91 ↑ +0.1

16 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Time to Interactive 🟥 13.2 s 🟥 15.5 s ↑ +17.5 %
Lighthouse Largest Contentful Paint 🟨 3.6 s 🟨 3.7 s ↑ +3.1 %
Lighthouse Total Blocking Time 🟥 2,710 ms 🟥 4,970 ms ↑ +83.3 %
Lighthouse First Contentful Paint 🟨 2.9 s 🟨 2.9 s ↑ +1.2 %
Code coverage Line coverage 🟨 89.9 % 🟨 90 % ↑ +0.1 %
Code coverage Branch coverage 🟨 85.9 % 🟨 85.9 % ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 12.3 s 🟥 16.8 s ↑ +36.5 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,835 KiB 🟩 Total size was 1,831 KiB ↓ −0.2 %
Lighthouse JavaScript execution time 🟥 5.5 s 🟥 8.0 s ↑ +43.8 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +17.5 %
Lighthouse Max Potential First Input Delay 🟥 1,330 ms 🟥 2,690 ms ↑ +102.5 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 860 ms 🟥 Potential savings of 1,130 ms ↑ +32.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Speed Index 🟨 5.6 s 🟨 5.6 s ↑ +0.9 %
Lighthouse Initial server response time was short 🟩 Root document took 580 ms 🟩 Root document took 550 ms ↓ −5.3 %
Lighthouse Server Backend Latencies 🟩 250 ms 🟩 260 ms ↑ +4.2 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 70 ms ↓ −0.7 %

579 other audits are unchanged.

Copy link
Collaborator

@vmasek vmasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is the same failing test, when it was happening to me I remember reading something about nx graph having some issues in nested git repositories (which we do have in test fixtures).

@matejchalk matejchalk merged commit 7936a00 into main Mar 5, 2025
15 of 16 checks passed
@matejchalk matejchalk deleted the fix-js-package-warning-lines branch March 5, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug something isn't working 🧩 js-packages-plugin Plugin for audit and outdated dependencies 🔬 testing writing tests 🧩 utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants