Skip to content

Conversation

@matejchalk
Copy link
Collaborator

Since the first parameter of mergeConfigs is a full CoreConfig, only the subsequent parameters are Partial<CoreConfig>s, then the result must be a full CoreConfig.

This removes the need to do mergeConfigs(...) as CoreConfig when using it.

@matejchalk matejchalk marked this pull request as ready for review March 4, 2025 09:54
@matejchalk matejchalk requested review from BioPhoton and vmasek March 4, 2025 09:54
vmasek
vmasek previously approved these changes Mar 4, 2025
Copy link
Collaborator

@vmasek vmasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes perfect sense, I do not recall why I left result partial (probably because all params were partial in initial design)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 038946a with previous commit ebb4ed5.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 52 🟡 53 ↑ +1.6
Code coverage 🟢 91 🟢 91
Security 🟡 75 🟡 75
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👍 1 group improved, 👍 2 audits improved, 👎 3 audits regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 52 🟡 53 ↑ +1.6

17 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.7 s 🟨 3.4 s ↓ −8.4 %
Lighthouse Speed Index 🟨 5.2 s 🟨 5.5 s ↑ +6.3 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟨 2.7 s ↓ −3.3 %
Lighthouse Total Blocking Time 🟥 2,900 ms 🟥 4,210 ms ↑ +45.2 %
Lighthouse Time to Interactive 🟥 13.3 s 🟥 13.9 s ↑ +4.8 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,827 KiB 🟩 Total size was 1,832 KiB ↑ +0.2 %
Lighthouse Minimizes main-thread work 🟥 12.4 s 🟥 15.6 s ↑ +26.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +4.8 %
Lighthouse JavaScript execution time 🟥 6.5 s 🟥 7.0 s ↑ +6.7 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 960 ms 🟥 Potential savings of 720 ms ↓ −25.3 %
Lighthouse Max Potential First Input Delay 🟥 1,670 ms 🟥 1,890 ms ↑ +13.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 67 KiB 🟥 Potential savings of 56 KiB ↓ −33.3 %
Lighthouse Server Backend Latencies 🟩 110 ms 🟩 70 ms ↓ −37 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 20 ms ↓ −18.8 %
Lighthouse Initial server response time was short 🟩 Root document took 550 ms 🟩 Root document took 550 ms ↓ −0.6 %

580 other audits are unchanged.

@matejchalk matejchalk merged commit 77fc37e into main Mar 4, 2025
14 of 16 checks passed
@matejchalk matejchalk deleted the fix-merge-configs-type branch March 4, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants