Skip to content

Conversation

@vmasek
Copy link
Collaborator

@vmasek vmasek commented Feb 19, 2025

closes #843
part of #888

Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement 👍 The environment variable opens the door to forwarding verbose flag to plugin runners.

@vmasek vmasek force-pushed the logging branch 2 times, most recently from ccd99df to 6d5ecfe Compare February 24, 2025 21:48
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 4c14ff7 with previous commit 21a1f25.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 55 🟡 51 ↓ −3.5
Code coverage 🟢 91 🟢 90 ↓ −0.1
Documentation 🔴 23 🔴 23 ↑ +0.1
Security 🟡 75 🟡 75
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 2 groups regressed, 👍 5 audits improved, 👎 5 audits regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 55 🟡 51 ↓ −3.5
Code coverage Code coverage metrics 🟢 91 🟢 90 ↓ −0.1
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↑ +0.1

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟨 4.8 s 🟨 5.8 s ↑ +20.9 %
Lighthouse Time to Interactive 🟥 12.5 s 🟥 15.4 s ↑ +23.4 %
Lighthouse Largest Contentful Paint 🟨 3.4 s 🟨 3.5 s ↑ +4.2 %
Lighthouse Total Blocking Time 🟥 2,960 ms 🟥 5,950 ms ↑ +100.9 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟨 2.7 s ↓ −2.5 %
Code coverage Function coverage 🟩 92.9 % 🟩 92.8 % ↓ −0.1 %
Code coverage Line coverage 🟨 89.8 % 🟨 89.9 % ↑ +0.1 %
JSDoc coverage Types coverage 🟥 209 undocumented types 🟥 208 undocumented types ↓ −0.5 %
Code coverage Branch coverage 🟨 86 % 🟨 86 % ↑ +0.1 %
JSDoc coverage Functions coverage 🟥 449 undocumented functions 🟥 447 undocumented functions ↓ −0.4 %
Lighthouse Minimizes main-thread work 🟥 12.3 s 🟥 16.7 s ↑ +35.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +23.4 %
Lighthouse JavaScript execution time 🟥 5.8 s 🟥 8.3 s ↑ +44.6 %
Lighthouse Max Potential First Input Delay 🟥 1,350 ms 🟥 2,260 ms ↑ +67.5 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,824 KiB 🟩 Total size was 1,824 KiB ↑ +0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 340 ms 🟩 Root document took 600 ms ↑ +77.2 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 970 ms 🟥 Potential savings of 820 ms ↓ −15.4 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 67 KiB 🟥 Potential savings of 67 KiB ↑ +45.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Network Round Trip Times 🟩 30 ms 🟩 20 ms ↓ −38.5 %
Lighthouse Server Backend Latencies 🟩 100 ms 🟩 110 ms ↑ +10.5 %

575 other audits are unchanged.

@vmasek vmasek requested a review from matejchalk February 25, 2025 09:03
@vmasek vmasek marked this pull request as ready for review February 25, 2025 09:26
@vmasek vmasek requested a review from BioPhoton as a code owner February 25, 2025 09:26
@vmasek vmasek enabled auto-merge (rebase) February 25, 2025 09:26
@vmasek vmasek merged commit 84b1e98 into main Feb 25, 2025
16 checks passed
@vmasek vmasek deleted the logging branch February 25, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log process stdout/stderr by default

3 participants