-
Notifications
You must be signed in to change notification settings - Fork 15
refactor: use CP_VERBOSE flag instead of verbose param #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
matejchalk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvement 👍 The environment variable opens the door to forwarding verbose flag to plugin runners.
packages/cli/src/lib/implementation/filter.middleware.unit.test.ts
Outdated
Show resolved
Hide resolved
ccd99df to
6d5ecfe
Compare
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 4c14ff7 with previous commit 21a1f25. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 2 groups regressed, 👍 5 audits improved, 👎 5 audits regressed, 11 audits changed without impacting score🗃️ Groups
15 other groups are unchanged. 🛡️ Audits
575 other audits are unchanged. |
closes #843
part of #888
CP_VERBOSEflag instead ofverboseparam passingexecuteRunnerConfignow printsstderrand logsstdoutin verbose modeutilspackage test