Skip to content

Conversation

@matejchalk
Copy link
Collaborator

Monorepos like Nx and Turborepo support task caching. Since collecting a Code PushUp report may be slow, it makes sense to configure caching for the code-pushup task, with report files as the cache output.

However, the CI integration also uses other CLI commands - print-config, compare and merge-diffs - which have different outputs. It would be more complex to configure cache outputs for these commands as well, and because these commands are typically only run "under the hood", we can't expect a user to know about them. Furthermore, these commands are much faster than collect/autorun, so caching them doesn't bring much benefit.

For the reasons outlined above, I've added CLI arguments to these commands that explicitly opt out of caching - --skip-nx-cache for Nx, --no-cache --force for Turborepo.

@matejchalk matejchalk marked this pull request as ready for review February 19, 2025 10:10
Copy link
Collaborator

@vmasek vmasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes perfect sense 🚀

@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit c867093 with source commit a277356.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 53 🔴 49 ↓ −3.2
Code coverage 🟢 91 🟢 91
Security 🟡 75 🟡 75
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👎 1 group regressed, 👍 1 audit improved, 👎 4 audits regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 53 🔴 49 ↓ −3.2

17 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟨 5.7 s 🟥 7.2 s ↑ +26.8 %
Lighthouse First Contentful Paint 🟨 3.0 s 🟨 2.9 s ↓ −4.1 %
Lighthouse Largest Contentful Paint 🟨 3.4 s 🟨 3.5 s ↑ +3.5 %
Lighthouse Time to Interactive 🟥 13.8 s 🟥 15.4 s ↑ +11.8 %
Lighthouse Total Blocking Time 🟥 3,250 ms 🟥 6,670 ms ↑ +105.3 %
Lighthouse Minimizes main-thread work 🟥 13.3 s 🟥 19.6 s ↑ +47.3 %
Lighthouse JavaScript execution time 🟥 6.5 s 🟥 8.5 s ↑ +31.6 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +11.8 %
Lighthouse Max Potential First Input Delay 🟥 1,500 ms 🟥 2,750 ms ↑ +82.6 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 840 ms 🟥 Potential savings of 660 ms ↓ −20.9 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,825 KiB 🟩 Total size was 1,825 KiB ↓ −0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 600 ms 🟩 Root document took 430 ms ↓ −27.4 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Server Backend Latencies 🟩 230 ms 🟩 220 ms ↓ −1.9 %
Lighthouse Network Round Trip Times 🟩 60 ms 🟩 50 ms ↓ −4.3 %
Code coverage Branch coverage 🟨 86 % 🟨 85.9 % ↓ −0.1 %

580 other audits are unchanged.

@matejchalk matejchalk merged commit 29a1bc6 into main Feb 19, 2025
17 checks passed
@matejchalk matejchalk deleted the ci-commands-skip-cache branch February 19, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants