Skip to content

Conversation

@vmasek
Copy link
Collaborator

@vmasek vmasek commented Feb 18, 2025

The runner with use: 'node20' in our GitHub action does not respect the Node 20 requirement and runs on Node 18 anyway, GitHub did not release a Node 22 runner for quite some time now and they do not communicate their plans at all, thus only reasonable thing we can do right now it to include a polyfill as execution of our code in action runner does not work and fails with no error in CI

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 5cf5d1f with source commit f5f226e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 53 🟡 53 ↑ +0.7
Code coverage 🟢 91 🟢 91 ↓ −0.1
Security 🟡 75 🟡 75
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Documentation 🔴 23 🔴 23
👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 6 audits regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 53 🟡 53 ↑ +0.7
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1

16 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.6 s 🟨 3.4 s ↓ −4.9 %
Lighthouse Total Blocking Time 🟥 2,910 ms 🟥 3,530 ms ↑ +21.2 %
Lighthouse Speed Index 🟨 5.3 s 🟨 5.4 s ↑ +0.9 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟨 2.8 s ↑ +1.6 %
Lighthouse Time to Interactive 🟥 13.2 s 🟥 13.6 s ↑ +2.7 %
Code coverage Line coverage 🟨 89.9 % 🟨 89.8 % ↓ −0.1 %
Code coverage Branch coverage 🟨 86 % 🟨 85.9 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,817 KiB 🟩 Total size was 1,822 KiB ↑ +0.2 %
Lighthouse Minimizes main-thread work 🟥 12.5 s 🟥 13.9 s ↑ +11.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +2.7 %
Lighthouse JavaScript execution time 🟥 6.5 s 🟥 6.3 s ↓ −3.8 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,000 ms 🟥 Potential savings of 820 ms ↓ −18 %
Lighthouse Server Backend Latencies 🟩 140 ms 🟩 230 ms ↑ +69.7 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 390 ms 🟩 Root document took 450 ms ↑ +17.6 %
Lighthouse Max Potential First Input Delay 🟥 1,710 ms 🟥 1,730 ms ↑ +1.3 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 67 KiB 🟥 Potential savings of 67 KiB ↑ +3.2 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 20 ms ↓ −15.4 %

578 other audits are unchanged.

@matejchalk matejchalk merged commit 55704d1 into main Feb 18, 2025
16 checks passed
@matejchalk matejchalk deleted the polyfill branch February 18, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants