Skip to content

Conversation

@hanna-skryl
Copy link
Collaborator

Closes #753

This PR implements deep merge for executor options, allowing CLI arguments to augment rather than override nested configurations.

@hanna-skryl hanna-skryl self-assigned this Jan 28, 2025
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 nx-plugin labels Jan 28, 2025
@hanna-skryl hanna-skryl marked this pull request as ready for review January 28, 2025 01:35
@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 6c53b5b with source commit e68ce12.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 48 🔴 49 ↑ +0.8
Documentation 🔴 23 🔴 23 ↑ +0.1
Code coverage 🟢 91 🟢 91 ↓ −0.1
Security 🟡 79 🟡 79
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 2 groups improved, 👎 1 group regressed, 👍 4 audits improved, 👎 5 audits regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 48 🔴 49 ↑ +0.8
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↑ +0.1
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 6.2 s 🟥 6.5 s ↑ +5.1 %
Lighthouse Largest Contentful Paint 🟨 3.8 s 🟨 3.7 s ↓ −3.8 %
Lighthouse First Contentful Paint 🟨 2.9 s 🟨 2.9 s ↓ −2.5 %
Lighthouse Time to Interactive 🟥 14.9 s 🟥 16.0 s ↑ +7.8 %
Lighthouse Total Blocking Time 🟥 4,210 ms 🟥 6,230 ms ↑ +47.9 %
JSDoc coverage Functions coverage 🟥 437 undocumented functions 🟥 437 undocumented functions  +0 %
Code coverage Branch coverage 🟨 86.1 % 🟨 86 % ↓ −0.1 %
Code coverage Line coverage 🟩 90.1 % 🟩 90.1 % ↓ −0.1 %
Code coverage Function coverage 🟩 93.1 % 🟩 93.1 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,818 KiB 🟩 Total size was 1,822 KiB ↑ +0.2 %
Lighthouse Minimizes main-thread work 🟥 15.0 s 🟥 18.5 s ↑ +23.9 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +7.8 %
Lighthouse JavaScript execution time 🟥 8.1 s 🟥 8.9 s ↑ +9.2 %
Lighthouse Max Potential First Input Delay 🟥 2,220 ms 🟥 2,450 ms ↑ +10.2 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 850 ms 🟥 Potential savings of 630 ms ↓ −26.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 67 KiB 🟥 Potential savings of 46 KiB ↓ −33.3 %
Lighthouse Server Backend Latencies 🟩 180 ms 🟩 330 ms ↑ +81.1 %
Lighthouse Initial server response time was short 🟩 Root document took 550 ms 🟩 Root document took 560 ms ↑ +0.9 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 70 ms ↓ −6.3 %

576 other audits are unchanged.

Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👍

@hanna-skryl hanna-skryl merged commit 3dcc4b1 into main Jan 28, 2025
17 checks passed
@hanna-skryl hanna-skryl deleted the fix/nx-plugin-persist-config branch January 28, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 nx-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

terminal options as object (--persist.format) overwrite the full property of nx-plugin:autorun executor options in package.json

4 participants