Skip to content

Conversation

@hanna-skryl
Copy link
Collaborator

Closes #757

This PR introduces a custom matcher, toContainMarkdownTableRow, designed to validate the presence of specific rows within Markdown tables during testing.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025

Code PushUp

😟 Code PushUp report has regressed – compared target commit 2628fac with source commit ec834db.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🟡 53 ↓ −1.5
Code coverage 🟢 91 🟢 91 ↓ −0.1
Security 🟡 79 🟡 79
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👎 2 groups regressed, 👎 5 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🟡 53 ↓ −1.5
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1

16 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.4 s 🟨 3.5 s ↑ +2.6 %
Lighthouse Time to Interactive 🟥 13.6 s 🟥 14.6 s ↑ +7.7 %
Lighthouse Total Blocking Time 🟥 2,960 ms 🟥 4,210 ms ↑ +42 %
Lighthouse First Contentful Paint 🟨 2.7 s 🟨 2.7 s ↑ +0.4 %
Code coverage Line coverage 🟩 90.1 % 🟩 90.1 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 13.0 s 🟥 14.8 s ↑ +13.9 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +7.7 %
Lighthouse JavaScript execution time 🟥 6.2 s 🟥 7.1 s ↑ +15.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,818 KiB 🟩 Total size was 1,818 KiB ↓ −0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 510 ms 🟩 Root document took 450 ms ↓ −13.4 %
Lighthouse Max Potential First Input Delay 🟥 1,830 ms 🟥 1,770 ms ↓ −3.1 %
Lighthouse Server Backend Latencies 🟩 150 ms 🟩 200 ms ↑ +31.5 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 820 ms 🟥 Potential savings of 810 ms ↓ −1.8 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 20 ms ↓ −33.5 %
Lighthouse Speed Index 🟨 5.4 s 🟨 5.4 s ↑ +0.1 %
Lighthouse Avoid large layout shifts 🟩 0 🟩 1 layout shift found ↑ +∞ %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0 ↑ +∞ %

578 other audits are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review January 24, 2025 02:10
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so much nicer to use 👍

@hanna-skryl hanna-skryl force-pushed the feat/markdown-table-matcher branch from fbfaf2d to c7fb5d5 Compare January 27, 2025 15:08
@hanna-skryl hanna-skryl merged commit e68ce12 into main Jan 27, 2025
16 checks passed
@hanna-skryl hanna-skryl deleted the feat/markdown-table-matcher branch January 27, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom matcher for Markdown tables

3 participants