-
Notifications
You must be signed in to change notification settings - Fork 15
refactor(plugin-js-packages): provide package json path + e2e test #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51b35db to
5f91da8
Compare
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit d0ac785 with previous commit f957c72. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👎 1 group regressed, 👍 6 audits improved, 👎 3 audits regressed, 12 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
582 other audits are unchanged. |
matejchalk
requested changes
Jan 6, 2025
e2e/plugin-js-packages-e2e/mocks/fixtures/npm-repo/code-pushup.config.ts
Outdated
Show resolved
Hide resolved
e2e/plugin-js-packages-e2e/tests/plugin-js-packages.e2e.test.ts
Outdated
Show resolved
Hide resolved
e2e/plugin-js-packages-e2e/mocks/fixtures/npm-repo/code-pushup.config.ts
Outdated
Show resolved
Hide resolved
e2e/plugin-js-packages-e2e/tests/plugin-js-packages.e2e.test.ts
Outdated
Show resolved
Hide resolved
e2e/plugin-js-packages-e2e/tests/plugin-js-packages.e2e.test.ts
Outdated
Show resolved
Hide resolved
e2e/plugin-js-packages-e2e/tests/plugin-js-packages.e2e.test.ts
Outdated
Show resolved
Hide resolved
e2e/plugin-js-packages-e2e/tests/plugin-js-packages.e2e.test.ts
Outdated
Show resolved
Hide resolved
e2e/plugin-js-packages-e2e/tests/plugin-js-packages.e2e.test.ts
Outdated
Show resolved
Hide resolved
matejchalk
reviewed
Jan 6, 2025
e2e/plugin-js-packages-e2e/tests/plugin-js-packages.e2e.test.ts
Outdated
Show resolved
Hide resolved
5f91da8 to
69de1d9
Compare
28e370e to
3f824bb
Compare
55eb048 to
29832fc
Compare
…rrent" is missing happens when package not installed
matejchalk
reviewed
Apr 1, 2025
matejchalk
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧩 js-packages-plugin
Plugin for audit and outdated dependencies
📖 Project documentation
improvements or additions to the project documentation
🔬 testing
writing tests
🛠️ tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.jsonpathpackageJsonPahtsthat was used just to count outdated depscurrenttowanted(currentis missing ifnode_modulesfolder does not exist and we audit just using package log)