Skip to content

Conversation

@vmasek
Copy link
Collaborator

@vmasek vmasek commented Dec 21, 2024

  • option to provide package.json path
  • remove confusing parameter of packageJsonPahts that was used just to count outdated deps
  • create e2e tests
  • fallback from current to wanted (current is missing if node_modules folder does not exist and we audit just using package log)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit d0ac785 with previous commit f957c72.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 39 🔴 50 ↑ +10.4
Code coverage 🟢 90 🟢 90 ↓ −0.1
Documentation 🔴 23 🔴 23 ↑ +0.1
Security 🟡 62 🟡 62
Updates 🟡 84 🟡 84
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 2 groups improved, 👎 1 group regressed, 👍 6 audits improved, 👎 3 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 39 🔴 50 ↑ +10.4
Code coverage Code coverage metrics 🟢 90 🟢 90 ↓ −0.1
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Contentful Paint 🟥 3.8 s 🟨 2.9 s ↓ −23.5 %
Lighthouse Largest Contentful Paint 🟥 4.5 s 🟨 3.6 s ↓ −19.2 %
Lighthouse Speed Index 🟥 7.7 s 🟥 6.1 s ↓ −21.1 %
Lighthouse Time to Interactive 🟥 15.6 s 🟥 13.0 s ↓ −17 %
JSDoc coverage Types coverage 🟥 213 undocumented types 🟥 212 undocumented types ↓ −0.5 %
Code coverage Line coverage 🟨 89.8 % 🟨 89.8 % ↓ −0.1 %
Code coverage Function coverage 🟩 92.8 % 🟩 92.8 % ↓ −0.1 %
JSDoc coverage Functions coverage 🟥 456 undocumented functions 🟥 455 undocumented functions ↓ −0.2 %
Code coverage Branch coverage 🟨 86 % 🟨 86 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 22.2 s 🟥 17.2 s ↓ −22.5 %
Lighthouse Total Blocking Time 🟥 7,730 ms 🟥 4,700 ms ↓ −39.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −17 %
Lighthouse JavaScript execution time 🟥 9.0 s 🟥 7.1 s ↓ −22 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,570 ms 🟥 Potential savings of 580 ms ↓ −63.3 %
Lighthouse Max Potential First Input Delay 🟥 3,050 ms 🟥 2,120 ms ↓ −30.5 %
Lighthouse Server Backend Latencies 🟩 200 ms 🟩 280 ms ↑ +39 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 530 ms 🟩 Root document took 480 ms ↓ −9.2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,839 KiB 🟩 Total size was 1,839 KiB ↑ +0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 67 KiB 🟥 Potential savings of 67 KiB ↑ +6.7 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 40 ms ↑ +76.9 %

582 other audits are unchanged.

@vmasek vmasek marked this pull request as ready for review January 2, 2025 21:42
@github-actions github-actions bot added the 🧩 js-packages-plugin Plugin for audit and outdated dependencies label Jan 24, 2025
@vmasek vmasek force-pushed the js-packages-e2e branch 2 times, most recently from 28e370e to 3f824bb Compare January 24, 2025 01:31
@vmasek vmasek force-pushed the js-packages-e2e branch 2 times, most recently from 55eb048 to 29832fc Compare April 1, 2025 00:00
@github-actions github-actions bot added the 📖 Project documentation improvements or additions to the project documentation label Apr 1, 2025
@vmasek vmasek force-pushed the js-packages-e2e branch from 29832fc to 5bf7b41 Compare April 1, 2025 09:50
@vmasek vmasek changed the title test(plugin-js-packages-e2e): create vulnerabilities e2e test refactor(plugin-js-packages): provide package json path + e2e test Apr 1, 2025
@vmasek vmasek requested a review from matejchalk April 1, 2025 09:54
…rrent" is missing

happens when package not installed
@vmasek vmasek force-pushed the js-packages-e2e branch from 5bf7b41 to 6d28e06 Compare April 1, 2025 09:58
@vmasek vmasek force-pushed the js-packages-e2e branch from 6d28e06 to 5592194 Compare April 1, 2025 11:40
@vmasek vmasek requested a review from matejchalk April 1, 2025 13:53
@vmasek vmasek merged commit 137392e into main Apr 1, 2025
16 checks passed
@vmasek vmasek deleted the js-packages-e2e branch April 1, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 js-packages-plugin Plugin for audit and outdated dependencies 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants