refactor: update eslint to flat config for all projects

.nvmrc

@@ -1 +1 @@
-20.11.0
+22.10.0

.tool-versions

@@ -1 +1 @@
-nodejs 20.11.0
+nodejs 22.10.0

docs/e2e.md

@@ -144,14 +144,14 @@ export default defineConfig({
 
 // to avoid port conflicts ever E2E targets has a unique port
 const uniquePort = 6000 + Math.round(Math.random() * 1000);
-const e2eDir = join('tmp', 'e2e');
+const e2eDir = path.join('tmp', 'e2e');
 
 export async function setup() {
   // start local verdaccio registry
   const { registry } = await startLocalRegistry({
     localRegistryTarget: '@code-pushup/cli-source:start-verdaccio',
     // to avoid file system conflicts ever E2E targets has a unique storage folder
-    storage: join(join(e2eDir, `registry-${uniquePort}`), 'storage'),
+    storage: path.join(path.join(e2eDir, `registry-${uniquePort}`), 'storage'),
     port: uniquePort,
   });
 

e2e/ci-e2e/eslint.config.js

@@ -0,0 +1,12 @@
+import tseslint from 'typescript-eslint';
+import baseConfig from '../../eslint.config.js';
+
+export default tseslint.config(...baseConfig, {
+  files: ['**/*.ts'],
+  languageOptions: {
+    parserOptions: {
+      projectService: true,
+      tsconfigRootDir: import.meta.dirname,
+    },
+  },
+});

e2e/ci-e2e/mocks/setup.ts

@@ -1,5 +1,5 @@
 import { cp } from 'node:fs/promises';
-import { dirname, join } from 'node:path';
+import path from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { simpleGit } from 'simple-git';
 import { nxTargetProject } from '@code-pushup/test-nx-utils';
@@ -14,12 +14,12 @@ import {
 export type TestRepo = Awaited<ReturnType<typeof setupTestRepo>>;
 
 export async function setupTestRepo(folder: string) {
-  const fixturesDir = join(
-    fileURLToPath(dirname(import.meta.url)),
+  const fixturesDir = path.join(
+    fileURLToPath(path.dirname(import.meta.url)),
     'fixtures',
     folder,
   );
-  const baseDir = join(
+  const baseDir = path.join(
     process.cwd(),
     E2E_ENVIRONMENTS_DIR,
     nxTargetProject(),

e2e/ci-e2e/tests/basic.e2e.test.ts

@@ -1,5 +1,5 @@
 import { readFile, rename } from 'node:fs/promises';
-import { join } from 'node:path';
+import path from 'node:path';
 import type { SimpleGit } from 'simple-git';
 import { afterEach } from 'vitest';
 import {
@@ -47,14 +47,14 @@ describe('CI - standalone mode', () => {
         mode: 'standalone',
         files: {
           report: {
-            json: join(repo.baseDir, '.code-pushup/report.json'),
-            md: join(repo.baseDir, '.code-pushup/report.md'),
+            json: path.join(repo.baseDir, '.code-pushup/report.json'),
+            md: path.join(repo.baseDir, '.code-pushup/report.md'),
           },
         },
       } satisfies RunResult);
 
       const jsonPromise = readFile(
-        join(repo.baseDir, '.code-pushup/report.json'),
+        path.join(repo.baseDir, '.code-pushup/report.json'),
         'utf8',
       );
       await expect(jsonPromise).resolves.toBeTruthy();
@@ -84,8 +84,8 @@ describe('CI - standalone mode', () => {
       await git.checkoutLocalBranch('feature-1');
 
       await rename(
-        join(repo.baseDir, 'index.js'),
-        join(repo.baseDir, 'index.ts'),
+        path.join(repo.baseDir, 'index.js'),
+        path.join(repo.baseDir, 'index.ts'),
       );
 
       await git.add('index.ts');
@@ -104,25 +104,27 @@ describe('CI - standalone mode', () => {
         newIssues: [],
         files: {
           report: {
-            json: join(repo.baseDir, '.code-pushup/report.json'),
-            md: join(repo.baseDir, '.code-pushup/report.md'),
+            json: path.join(repo.baseDir, '.code-pushup/report.json'),
+            md: path.join(repo.baseDir, '.code-pushup/report.md'),
           },
           diff: {
-            json: join(repo.baseDir, '.code-pushup/report-diff.json'),
-            md: join(repo.baseDir, '.code-pushup/report-diff.md'),
+            json: path.join(repo.baseDir, '.code-pushup/report-diff.json'),
+            md: path.join(repo.baseDir, '.code-pushup/report-diff.md'),
           },
         },
       } satisfies RunResult);
 
       const mdPromise = readFile(
-        join(repo.baseDir, '.code-pushup/report-diff.md'),
+        path.join(repo.baseDir, '.code-pushup/report-diff.md'),
         'utf8',
       );
       await expect(mdPromise).resolves.toBeTruthy();
       const md = await mdPromise;
       await expect(
         md.replace(/[\da-f]{40}/g, '`<commit-sha>`'),
-      ).toMatchFileSnapshot(join(TEST_SNAPSHOTS_DIR, 'basic-report-diff.md'));
+      ).toMatchFileSnapshot(
+        path.join(TEST_SNAPSHOTS_DIR, 'basic-report-diff.md'),
+      );
     });
   });
 });

e2e/ci-e2e/tests/npm-workspaces.e2e.test.ts

@@ -1,5 +1,5 @@
 import { readFile, rename } from 'node:fs/promises';
-import { join } from 'node:path';
+import path from 'node:path';
 import type { SimpleGit } from 'simple-git';
 import { afterEach } from 'vitest';
 import {
@@ -53,11 +53,14 @@ describe('CI - monorepo mode (npm workspaces)', () => {
             name: '@example/cli',
             files: {
               report: {
-                json: join(
+                json: path.join(
                   repo.baseDir,
                   'packages/cli/.code-pushup/report.json',
                 ),
-                md: join(repo.baseDir, 'packages/cli/.code-pushup/report.md'),
+                md: path.join(
+                  repo.baseDir,
+                  'packages/cli/.code-pushup/report.md',
+                ),
               },
             },
           },
@@ -66,7 +69,7 @@ describe('CI - monorepo mode (npm workspaces)', () => {
 
       await expect(
         readJsonFile(
-          join(repo.baseDir, 'packages/cli/.code-pushup/report.json'),
+          path.join(repo.baseDir, 'packages/cli/.code-pushup/report.json'),
         ),
       ).resolves.toEqual(
         expect.objectContaining({
@@ -92,16 +95,16 @@ describe('CI - monorepo mode (npm workspaces)', () => {
       await git.checkoutLocalBranch('feature-1');
 
       await rename(
-        join(repo.baseDir, 'packages/cli/src/bin.js'),
-        join(repo.baseDir, 'packages/cli/src/bin.ts'),
+        path.join(repo.baseDir, 'packages/cli/src/bin.js'),
+        path.join(repo.baseDir, 'packages/cli/src/bin.ts'),
       );
       await rename(
-        join(repo.baseDir, 'packages/core/src/index.js'),
-        join(repo.baseDir, 'packages/core/src/index.ts'),
+        path.join(repo.baseDir, 'packages/core/src/index.js'),
+        path.join(repo.baseDir, 'packages/core/src/index.ts'),
       );
       await rename(
-        join(repo.baseDir, 'packages/core/code-pushup.config.js'),
-        join(repo.baseDir, 'packages/core/code-pushup.config.ts'),
+        path.join(repo.baseDir, 'packages/core/code-pushup.config.js'),
+        path.join(repo.baseDir, 'packages/core/code-pushup.config.ts'),
       );
 
       await git.add('.');
@@ -117,24 +120,27 @@ describe('CI - monorepo mode (npm workspaces)', () => {
       await expect(runInCI(refs, MOCK_API, options, git)).resolves.toEqual({
         mode: 'monorepo',
         commentId: MOCK_COMMENT.id,
-        diffPath: join(repo.baseDir, '.code-pushup/merged-report-diff.md'),
+        diffPath: path.join(repo.baseDir, '.code-pushup/merged-report-diff.md'),
         projects: expect.arrayContaining<ProjectRunResult>([
           {
             name: '@example/core',
             files: {
               report: {
-                json: join(
+                json: path.join(
                   repo.baseDir,
                   'packages/core/.code-pushup/report.json',
                 ),
-                md: join(repo.baseDir, 'packages/core/.code-pushup/report.md'),
+                md: path.join(
+                  repo.baseDir,
+                  'packages/core/.code-pushup/report.md',
+                ),
               },
               diff: {
-                json: join(
+                json: path.join(
                   repo.baseDir,
                   'packages/core/.code-pushup/report-diff.json',
                 ),
-                md: join(
+                md: path.join(
                   repo.baseDir,
                   'packages/core/.code-pushup/report-diff.md',
                 ),
@@ -146,15 +152,15 @@ describe('CI - monorepo mode (npm workspaces)', () => {
       } satisfies RunResult);
 
       const mdPromise = readFile(
-        join(repo.baseDir, '.code-pushup/merged-report-diff.md'),
+        path.join(repo.baseDir, '.code-pushup/merged-report-diff.md'),
         'utf8',
       );
       await expect(mdPromise).resolves.toBeTruthy();
       const md = await mdPromise;
       await expect(
         md.replace(/[\da-f]{40}/g, '`<commit-sha>`'),
       ).toMatchFileSnapshot(
-        join(TEST_SNAPSHOTS_DIR, 'npm-workspaces-report-diff.md'),
+        path.join(TEST_SNAPSHOTS_DIR, 'npm-workspaces-report-diff.md'),
       );
     });
   });