Skip to content

Conversation

@matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Nov 29, 2024

Request from Nx customer where they need some custom projects filters. Forwarding args to nx show projects gives the most flexibility. Option is Nx specific because other monorepo tools are based on package.jsons, so don't have a CLI for listing projects.

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 ci labels Nov 29, 2024
@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit eeb2174 with source commit 13579f3.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🟡 55 ↑ +0.9
Custom checks 🟢 100 🟢 100
Code coverage 🟢 90 🟢 90
Security 🟡 78 🟡 78
Updates 🟡 76 🟡 76
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👍 2 audits improved, 👎 2 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🟡 55 ↑ +0.9

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 6.1 s 🟨 5.4 s ↓ −12.5 %
Lighthouse First Contentful Paint 🟨 3.0 s 🟥 3.0 s ↑ +1.2 %
Lighthouse Largest Contentful Paint 🟨 3.0 s 🟨 3.0 s ↑ +1.2 %
Lighthouse Time to Interactive 🟥 16.7 s 🟥 15.9 s ↓ −4.6 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,827 KiB 🟩 Total size was 1,822 KiB ↓ −0.2 %
Lighthouse JavaScript execution time 🟥 9.3 s 🟥 11.7 s ↑ +25.2 %
Lighthouse Minimizes main-thread work 🟥 18.9 s 🟥 20.7 s ↑ +9.4 %
Lighthouse Total Blocking Time 🟥 6,790 ms 🟥 8,110 ms ↑ +19.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −4.6 %
Lighthouse Uses efficient cache policy on static assets 🟨 29 resources found 🟨 29 resources found ↓ −0.1 %
Lighthouse Max Potential First Input Delay 🟥 2,930 ms 🟥 3,050 ms ↑ +4 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,510 ms 🟥 Potential savings of 1,440 ms ↓ −4.7 %
Lighthouse Initial server response time was short 🟩 Root document took 450 ms 🟩 Root document took 380 ms ↓ −15.3 %
Lighthouse Server Backend Latencies 🟩 100 ms 🟩 80 ms ↓ −17.2 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 10 ms ↓ −46.9 %
Lighthouse Avoids an excessive DOM size 🟥 2,207 elements 🟥 2,212 elements ↑ +0.2 %
Code coverage Branch coverage 🟨 85.1 % 🟨 85.1 % ↑ +0.1 %
Code coverage Line coverage 🟩 90.5 % 🟩 90.5 % ↑ +0.1 %

495 other audits are unchanged.

@matejchalk matejchalk marked this pull request as ready for review November 29, 2024 13:21
@matejchalk matejchalk merged commit 93a6a42 into main Nov 29, 2024
19 checks passed
@matejchalk matejchalk deleted the ci-nx-extra-args branch November 29, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 ci 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants