Skip to content

Conversation

@hanna-skryl
Copy link
Collaborator

@hanna-skryl hanna-skryl commented Dec 29, 2025

Closes #1135

  • Add setupScript option for testing login-protected pages
  • Refactor browser management from standalone functions to AxeRunner class for cleaner lifecycle handling
  • Updated Zod to v4.2.1 across all packages. This was required because Zod v4.1.5 fixed the z.function() type inference, which is now used for validating the setup function signature.
  • Refactored docsUrlSchema for Zod v4 compatibility
  • Tested with a real Angular application behind username/password authentication

@hanna-skryl hanna-skryl self-assigned this Dec 29, 2025
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 models 🛠️ tooling 🧩 axe-plugin labels Dec 29, 2025
@nx-cloud
Copy link

nx-cloud bot commented Dec 29, 2025

View your CI Pipeline Execution ↗ for commit f0793e7

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 28s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 45s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 47s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-30 00:04:25 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 29, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1198

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1198

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1198

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1198

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1198

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1198

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1198

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1198

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1198

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1198

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1198

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1198

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1198

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1198

commit: f0793e7

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit ca38464 with previous commit f51d768.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 36 🔴 40 ↑ +3.9
Performance 🔴 41 🔴 40 ↓ −1.1
Code coverage 🟡 89 🟡 89 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Bug prevention 🟡 67 🟡 67
Code style 🟢 99 🟢 99
Security 🟡 51 🟡 51
Updates 🟡 79 🟡 79
Type Safety 🟡 56 🟡 56
Miscellaneous 🟡 67 🟡 67
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 1 group improved, 👎 2 groups regressed, 👍 7 audits improved, 👎 6 audits regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 36 🔴 40 ↑ +3.9
Lighthouse Performance 🔴 41 🔴 40 ↓ −1.1
Code coverage Code coverage metrics 🟡 89 🟡 89 ↓ −0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟩 Root document took 470 ms 🟥 Root document took 650 ms ↑ +39 %
Lighthouse Speed Index 🟨 5.6 s 🟥 6.6 s ↑ +18.3 %
JSDocs coverage Methods coverage 🟨 8 undocumented methods 🟨 8 undocumented methods  +0 %
JSDocs coverage Classes coverage 🟥 6 undocumented classes 🟥 6 undocumented classes  +0 %
JSDocs coverage Variables coverage 🟥 267 undocumented variables 🟥 260 undocumented variables ↓ −2.6 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.1 s ↓ −2 %
JSDocs coverage Functions coverage 🟥 587 undocumented functions 🟥 573 undocumented functions ↓ −2.4 %
Lighthouse Time to Interactive 🟥 12.5 s 🟥 12.7 s ↑ +2.3 %
Lighthouse Total Blocking Time 🟥 1,220 ms 🟥 1,200 ms ↓ −1.6 %
Code coverage Line coverage 🟨 84.7 % 🟨 84.6 % ↓ −0.1 %
JSDocs coverage Types coverage 🟥 246 undocumented types 🟥 247 undocumented types ↑ +0.4 %
Code coverage Function coverage 🟩 90.9 % 🟩 90.9 % ↑ +0.1 %
Code coverage Branch coverage 🟨 87.2 % 🟨 87.2 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,065 KiB 🟩 Total size was 2,048 KiB ↓ −0.8 %
Lighthouse Server Backend Latencies 🟩 1,260 ms 🟩 320 ms ↓ −75 %
Lighthouse Largest Contentful Paint 🟥 11.6 s 🟥 11.0 s ↓ −5 %
Lighthouse JavaScript execution time 🟥 3.2 s 🟥 3.7 s ↑ +18.1 %
Lighthouse Minimizes main-thread work 🟥 8.2 s 🟥 8.6 s ↑ +4.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +2.3 %
Lighthouse Max Potential First Input Delay 🟥 880 ms 🟥 1,110 ms ↑ +26 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 95 KiB 🟥 Potential savings of 95 KiB ↓ −29.7 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 105 KiB 🟥 Potential savings of 104 KiB ↓ −29.7 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 190 KiB 🟥 Potential savings of 190 KiB ↓ −5.3 %
Lighthouse Network Round Trip Times 🟩 30 ms 🟩 70 ms ↑ +178.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
TypeScript Semantic errors 🟥 2581 errors 🟥 2550 errors ↓ −1.2 %
JSDocs coverage Properties coverage 🟥 16 undocumented properties 🟥 19 undocumented properties ↑ +18.8 %
JS packages Outdated npm prod dependencies. 🟨 16 outdated package versions (5 major, 8 minor, 3 patch) 🟨 15 outdated package versions (5 major, 7 minor, 3 patch) ↓ −6.2 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0 ↓ −100 %

650 other audits are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit ca38464 with previous commit f51d768.

💼 Project plugin-axe

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 67 🟡 70 ↑ +2.5
Code coverage 🟢 93 🟢 92 ↓ −0.3

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 3 audits regressed, 1 audit changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🟡 67 🟡 70 ↑ +2.5
Code coverage Code coverage metrics 🟢 93 🟢 92 ↓ −0.3

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Properties coverage 🟩 0 undocumented properties 🟥 3 undocumented properties ↑ +∞ %
JSDocs coverage Functions coverage 🟥 24 undocumented functions 🟨 10 undocumented functions ↓ −58.3 %
JSDocs coverage Variables coverage 🟥 19 undocumented variables 🟥 12 undocumented variables ↓ −36.8 %
Code coverage Line coverage 🟨 69.5 % 🟨 68.4 % ↓ −1.6 %
Code coverage Branch coverage 🟨 86.2 % 🟨 85.4 % ↓ −0.9 %
JSDocs coverage Types coverage 🟥 8 undocumented types 🟥 9 undocumented types ↑ +12.5 %

437 other audits are unchanged.

💼 Project models

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 93 🟢 93 ↓ −0.1

3 other categories are unchanged.

👎 1 group regressed, 👎 2 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 93 🟢 93 ↓ −0.1

11 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟩 91.5 % 🟩 91.4 % ↓ −0.1 %
Code coverage Line coverage 🟩 97.2 % 🟩 97.2 % ↓ −0.1 %

435 other audits are unchanged.

💼 Project plugin-lighthouse

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 99 🟢 99 ↓ −0.1

5 other categories are unchanged.

👎 1 group regressed, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 99 🟢 99 ↓ −0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟩 96.2 % 🟩 96.2 % ↓ −0.1 %

443 other audits are unchanged.


11 other projects are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review December 30, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Axe Plugin - Authentication Support

2 participants