Skip to content

Conversation

@matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Dec 2, 2025

Our log grouping is somewhat broken in Nx monorepo mode. This is because both Nx and our CLI produce native GitHub Actions log groups, but those currently don't support nesting (see actions/toolkit#1001). The result is that Nx targets aren't collapsed properly.

image

I added a check for the NX_TASK_TARGET_TARGET environment variable to detect if we're running within Nx, and use the regular log groups instead.

image

Because I'd still like to see our native GitHub log groups in action somewhere, I changed the standalone mode execution to not use Nx at all.

image

@nx-cloud
Copy link

nx-cloud bot commented Dec 2, 2025

View your CI Pipeline Execution ↗ for commit 96b3bfa

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 23s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 18s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-03 11:04:02 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 2, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1160

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1160

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1160

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1160

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1160

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1160

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1160

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1160

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1160

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1160

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1160

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1160

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1160

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1160

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1160

commit: 96b3bfa

@matejchalk matejchalk force-pushed the fix-nested-github-actions-log-groups branch from 06e8470 to 1cb6687 Compare December 2, 2025 16:31
@matejchalk matejchalk force-pushed the fix-nested-github-actions-log-groups branch from 1cb6687 to 7dd0715 Compare December 2, 2025 16:37
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 4cf2d49 with previous commit 068984b.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 38 🔴 36 ↓ −2.5
Code coverage 🟡 89 🟡 89 ↑ +0.1
Bug prevention 🟡 67 🟡 67
Code style 🟢 100 🟢 100
Security 🔴 43 🔴 43
Updates 🟡 71 🟡 71
Type Safety 🟡 56 🟡 56
Miscellaneous 🟡 67 🟡 67
Documentation 🔴 35 🔴 35
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 1 group improved, 👎 1 group regressed, 👍 4 audits improved, 👎 2 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 38 🔴 36 ↓ −2.5
Code coverage Code coverage metrics 🟡 89 🟡 89 ↑ +0.1

21 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 690 ms 🟩 Root document took 500 ms ↓ −27.6 %
Lighthouse Total Blocking Time 🟥 1,180 ms 🟥 1,870 ms ↑ +59.1 %
Lighthouse First Contentful Paint 🟥 3.5 s 🟥 3.1 s ↓ −10.4 %
Lighthouse Time to Interactive 🟥 12.9 s 🟥 13.2 s ↑ +1.8 %
Lighthouse Speed Index 🟥 6.8 s 🟥 6.8 s ↓ −1 %
Code coverage Branch coverage 🟨 87.2 % 🟨 87.2 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,095 KiB 🟩 Total size was 2,050 KiB ↓ −2.1 %
Lighthouse Minimizes main-thread work 🟥 9.6 s 🟥 12.3 s ↑ +28.2 %
Lighthouse JavaScript execution time 🟥 3.8 s 🟥 4.7 s ↑ +25.1 %
Lighthouse Max Potential First Input Delay 🟥 1,140 ms 🟥 1,530 ms ↑ +33.7 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 94 KiB 🟥 Potential savings of 94 KiB ↑ +110 %
Lighthouse Largest Contentful Paint 🟥 11.9 s 🟥 12.2 s ↑ +2.7 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +1.7 %
Lighthouse Server Backend Latencies 🟩 1,560 ms 🟩 1,330 ms ↓ −14.5 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 186 KiB 🟥 Potential savings of 186 KiB ↑ +26.7 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 105 KiB 🟥 Potential savings of 105 KiB ↑ +60 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 30 ms ↓ −64 %
TypeScript Semantic errors 🟥 2613 errors 🟥 2619 errors ↑ +0.2 %
Code coverage Line coverage 🟨 84.5 % 🟨 84.5 % ↑ +0.1 %

658 other audits are unchanged.

@BioPhoton
Copy link
Collaborator

I like that we keep it in standalone active!

@matejchalk matejchalk force-pushed the fix-nested-github-actions-log-groups branch from 7dd0715 to 5902bac Compare December 3, 2025 09:45
@matejchalk matejchalk force-pushed the fix-nested-github-actions-log-groups branch from 5902bac to 96b3bfa Compare December 3, 2025 10:47
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Code PushUp

🥳 Code PushUp report has improved – compared current commit 4cf2d49 with previous commit 068984b.

💼 Project plugin-lighthouse

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 99 🟢 99 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved, 👍 1 audit improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 99 🟢 99 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟩 96.1 % 🟩 96.1 % ↑ +0.1 %

442 other audits are unchanged.

💼 Project utils

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 94 🟢 94 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved, 👍 1 audit improved, 1 audit changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 94 🟢 94 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟩 91.9 % 🟩 91.9 % ↑ +0.1 %
Code coverage Line coverage 🟩 97 % 🟩 97 % ↑ +0.1 %

441 other audits are unchanged.


12 other projects are unchanged.

@matejchalk matejchalk marked this pull request as ready for review December 3, 2025 11:04
@matejchalk matejchalk merged commit fd8b0bc into main Dec 3, 2025
24 checks passed
@matejchalk matejchalk deleted the fix-nested-github-actions-log-groups branch December 3, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants