-
Notifications
You must be signed in to change notification settings - Fork 15
fix(utils): prevent nested github actions log groups when run within nx target #1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit 96b3bfa
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
06e8470 to
1cb6687
Compare
1cb6687 to
7dd0715
Compare
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 4cf2d49 with previous commit 068984b. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 4 audits improved, 👎 2 audits regressed, 14 audits changed without impacting score🗃️ Groups
21 other groups are unchanged. 🛡️ Audits
658 other audits are unchanged. |
|
I like that we keep it in standalone active! |
7dd0715 to
5902bac
Compare
5902bac to
96b3bfa
Compare
Code PushUp🥳 Code PushUp report has improved – compared current commit 4cf2d49 with previous commit 068984b. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 99 | 🟢 99 |
5 other categories are unchanged.
👍 1 group improved, 👍 1 audit improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 99 | 🟢 99 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟩 96.1 % | 🟩 96.1 % |
442 other audits are unchanged.
💼 Project utils
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 94 | 🟢 94 |
5 other categories are unchanged.
👍 1 group improved, 👍 1 audit improved, 1 audit changed without impacting score
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 94 | 🟢 94 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟩 91.9 % | 🟩 91.9 % | |
| Code coverage | Line coverage | 🟩 97 % | 🟩 97 % |
441 other audits are unchanged.
12 other projects are unchanged.
Our log grouping is somewhat broken in Nx monorepo mode. This is because both Nx and our CLI produce native GitHub Actions log groups, but those currently don't support nesting (see actions/toolkit#1001). The result is that Nx targets aren't collapsed properly.
I added a check for the
NX_TASK_TARGET_TARGETenvironment variable to detect if we're running within Nx, and use the regular log groups instead.Because I'd still like to see our native GitHub log groups in action somewhere, I changed the standalone mode execution to not use Nx at all.