-
Notifications
You must be signed in to change notification settings - Fork 15
fix(plugin-js-packages): pnpm outdated fallback #1155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit 12174df
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit d9afe13 with previous commit e1152f2. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 1 group regressed, 👍 1 audit improved, 👎 3 audits regressed, 15 audits changed without impacting score🗃️ Groups
22 other groups are unchanged. 🛡️ Audits
659 other audits are unchanged. |
matejchalk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks for the fix 👍
This bug surfaced in CI when a pull request removed a dependency.
The Code PushUp GitHub Action installs dependencies for the PR branch, which no longer includes the removed package in
node_modules. When the action switches to the base branch for comparison, it does not reinstall dependencies. The base branch'spackage.jsonstill references the removed dependency, sopnpm outdated --jsonreports it but without a current field since the package is not innode_modules.Example
The plugin then crashes when calling
semver.clean(undefined)on the missingcurrentvalue.