Skip to content

Conversation

@matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Oct 29, 2025

Fixes type errors in vitest.config.ts files. TypeScript doesn't recognize the test property unless defineConfig is imported from vitest/config, not vite (different UserConfig types).

🖼️ before image
🖼️ after image

@nx-cloud
Copy link

nx-cloud bot commented Oct 29, 2025

View your CI Pipeline Execution ↗ for commit 1377ab9

Command Status Duration Result
nx code-pushup --nx-bail -- compare ✅ Succeeded 57s View ↗
nx code-pushup --nx-bail -- ✅ Succeeded 1m 8s View ↗
nx code-pushup --nx-bail -- print-config --outp... ✅ Succeeded 3m 54s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-29 15:27:47 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 29, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1131

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1131

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1131

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1131

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1131

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1131

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1131

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1131

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1131

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1131

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1131

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1131

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1131

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1131

commit: 1377ab9

@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 9e1c657 with previous commit 4cd96b6.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 36 🔴 36 ↑ +0.4
Documentation 🔴 36 🔴 36 ↓ −0.1
Code coverage 🟢 90 🟢 90
Security 🟡 56 🟡 56
Updates 🟡 73 🟡 73
Accessibility 🟢 92 🟢 92
Best Practices 🟢 97 🟢 97
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 36 🔴 36 ↑ +0.4
JSDoc coverage Documentation coverage 🔴 36 🔴 36 ↓ −0.1

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 7.0 s 🟥 6.8 s ↓ −3.4 %
Lighthouse Time to Interactive 🟥 13.3 s 🟥 12.9 s ↓ −3.1 %
Lighthouse First Contentful Paint 🟥 3.0 s 🟥 3.0 s ↓ −1.5 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,029 KiB 🟩 Total size was 2,038 KiB ↑ +0.5 %
Lighthouse Server Backend Latencies 🟩 120 ms 🟩 1,580 ms ↑ +1182.2 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −3.1 %
Lighthouse JavaScript execution time 🟥 5.0 s 🟥 4.7 s ↓ −7.4 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 180 KiB 🟥 Potential savings of 180 KiB ↑ +46.9 %
Lighthouse Largest Contentful Paint 🟥 11.4 s 🟥 11.1 s ↓ −2.5 %
Lighthouse Max Potential First Input Delay 🟥 1,460 ms 🟥 1,180 ms ↓ −19.3 %
Lighthouse Minimizes main-thread work 🟥 12.3 s 🟥 12.5 s ↑ +1.7 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 103 KiB 🟥 Potential savings of 103 KiB ↑ +46.9 %
Lighthouse Initial server response time was short 🟩 Root document took 540 ms 🟩 Root document took 460 ms ↓ −15.6 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse Total Blocking Time 🟥 1,870 ms 🟥 1,880 ms ↑ +0.7 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 103 KiB 🟥 Potential savings of 103 KiB ↓ −3.1 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 30 ms ↑ +7.4 %

593 other audits are unchanged.

@matejchalk matejchalk marked this pull request as ready for review October 29, 2025 15:19
@matejchalk matejchalk requested a review from BioPhoton as a code owner October 29, 2025 15:19
@matejchalk matejchalk merged commit 471c847 into main Oct 29, 2025
23 checks passed
@matejchalk matejchalk deleted the type-safe-vitest-config branch October 29, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants